Skip to content

Fix the overflow error by changing maxInt #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 9, 2019
Merged

Fix the overflow error by changing maxInt #584

merged 4 commits into from
Aug 9, 2019

Conversation

rouzbeh-afrasiabi
Copy link
Contributor

csv.field_size_limit input was changed from sys.maxsize to maxInt. This Will resolve the "OverflowError: Python int too large to convert to C" error.

@zhangguanheng66 zhangguanheng66 changed the title Rouzbeh afrasiabi patch 1 Fix the overflow error by changing maxInt Aug 9, 2019
zhangguanheng66
zhangguanheng66 requested changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@zhangguanheng66 zhangguanheng66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run "flake8 /torchtext/utils.py" to reproduce the lint errors.

rouzbeh-afrasiabi
rouzbeh-afrasiabi commented Aug 9, 2019
View reviewed changes
Copy link
Contributor Author

@rouzbeh-afrasiabi rouzbeh-afrasiabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace removed

@zhangguanheng66 zhangguanheng66 merged commit 9164f42 into pytorch:master Aug 9, 2019
@rouzbeh-afrasiabi rouzbeh-afrasiabi deleted the rouzbeh-afrasiabi-patch-1 branch August 9, 2019 20:44
@peterjc123 peterjc123 mentioned this pull request Nov 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangguanheng66 zhangguanheng66 zhangguanheng66 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rouzbeh-afrasiabi @zhangguanheng66