Make checkpoint fail_fast feature optional #1310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: While fail_fast checkpointing is useful, it can also waste time and storage when the cluster is verified with TorchTitan. Make fail_fast feature as optional and defaults to False.
facebook-github-bot
added
the
CLA Signed
wwwjn
reviewed
Jun 17, 2025
wwwjn
approved these changes
Jun 18, 2025
H-Huang
pushed a commit
to H-Huang/torchtitan
that referenced
this pull request
Jun 26, 2025
While fail_fast checkpointing feature is useful, it can also waste time and storage when the cluster is already verified with TorchTitan. This PR makes fail_fast feature as optional and defaults to False.
wwwjn
pushed a commit
that referenced
this pull request
Jul 1, 2025
While fail_fast checkpointing feature is useful, it can also waste time and storage when the cluster is already verified with TorchTitan. This PR makes fail_fast feature as optional and defaults to False.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While fail_fast checkpointing feature is useful, it can also waste time and storage when the cluster is already verified with TorchTitan. This PR makes fail_fast feature as optional and defaults to False.