-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Fix quantization tutorials (imports, syntax, and style) #1763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This commit fixes the quantization tutorials such that they can be run smoothly by the user. Test Plan: Ran the updated tutorials without problem. Reviewers: jerryzh168 Subscribers: jerryzh168, supriyar [ghstack-poisoned]
jerryzh168
approved these changes
Dec 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Thanks! I'm merging this. |
Wait, this was never merged into master. I opened a new PR here that merges the exact same changes to master: #1772 |
jcaip
added a commit
that referenced
this pull request
Sep 6, 2022
* Fix quantization tutorials (imports, syntax, and style) Summary: This commit fixes the quantization tutorials such that they can be run smoothly by the user. Test Plan: Ran the updated tutorials without problem. Reviewers: jerryzh168 Subscribers: jerryzh168, supriyar ghstack-source-id: 196719d Pull Request resolved: #1763 * Fix quantization tutorials (imports, syntax, and style) Summary: This commit fixes the quantization tutorials such that they can be run smoothly by the user. Test Plan: Ran the updated tutorials without problem. Reviewers: jerryzh168 Subscribers: jerryzh168, supriyar ghstack-source-id: 196719d Pull Request resolved: #1763 * revert paths for wikitext version * Fix broken url Co-authored-by: Jesse Cai <[email protected]> Co-authored-by: Jesse Cai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary: This commit fixes the quantization tutorials such that
they can be run smoothly by the user.
Test Plan: Ran the updated tutorials without problem.
Reviewers: jerryzh168
Subscribers: jerryzh168, supriyar