Skip to content

Fix quantization tutorials (imports, syntax, and style) #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

andrewor14
Copy link
Contributor

@andrewor14 andrewor14 commented Dec 13, 2021

Stack from ghstack:

Summary: This commit fixes the quantization tutorials such that
they can be run smoothly by the user.

Test Plan: Ran the updated tutorials without problem.

Reviewers: jerryzh168

Subscribers: jerryzh168, supriyar

Summary: This commit fixes the quantization tutorials such that
they can be run smoothly by the user.

Test Plan: Ran the updated tutorials without problem.

Reviewers: jerryzh168

Subscribers: jerryzh168, supriyar

[ghstack-poisoned]
andrewor14 added a commit that referenced this pull request Dec 13, 2021
Summary: This commit fixes the quantization tutorials such that
they can be run smoothly by the user.

Test Plan: Ran the updated tutorials without problem.

Reviewers: jerryzh168

Subscribers: jerryzh168, supriyar

ghstack-source-id: 196719d
Pull Request resolved: #1763
Copy link
Contributor

@jerryzh168 jerryzh168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@andrewor14
Copy link
Contributor Author

Thanks! I'm merging this.

@andrewor14 andrewor14 merged commit def3164 into gh/andrewor14/1/base Dec 15, 2021
@andrewor14 andrewor14 deleted the gh/andrewor14/1/head branch December 15, 2021 20:25
@andrewor14 andrewor14 restored the gh/andrewor14/1/head branch December 20, 2021 18:45
@andrewor14
Copy link
Contributor Author

andrewor14 commented Dec 20, 2021

Wait, this was never merged into master. I opened a new PR here that merges the exact same changes to master: #1772

andrewor14 added a commit that referenced this pull request Dec 20, 2021
Summary: This commit fixes the quantization tutorials such that
they can be run smoothly by the user.

Test Plan: Ran the updated tutorials without problem.

Reviewers: jerryzh168

Subscribers: jerryzh168, supriyar

ghstack-source-id: 196719d
Pull Request resolved: #1763
@andrewor14 andrewor14 deleted the gh/andrewor14/1/head branch December 20, 2021 18:49
andrewor14 added a commit that referenced this pull request Dec 22, 2021
Summary: This commit fixes the quantization tutorials such that
they can be run smoothly by the user.

Test Plan: Ran the updated tutorials without problem.

Reviewers: jerryzh168

Subscribers: jerryzh168, supriyar

ghstack-source-id: 196719d
Pull Request resolved: #1763
andrewor14 added a commit that referenced this pull request Dec 22, 2021
Summary: This commit fixes the quantization tutorials such that
they can be run smoothly by the user.

Test Plan: Ran the updated tutorials without problem.

Reviewers: jerryzh168

Subscribers: jerryzh168, supriyar

ghstack-source-id: 196719d
Pull Request resolved: #1763
andrewor14 added a commit that referenced this pull request Feb 16, 2022
Summary: This commit fixes the quantization tutorials such that
they can be run smoothly by the user.

Test Plan: Ran the updated tutorials without problem.

Reviewers: jerryzh168

Subscribers: jerryzh168, supriyar

ghstack-source-id: 196719d
Pull Request resolved: #1763
jcaip pushed a commit that referenced this pull request Aug 31, 2022
Summary: This commit fixes the quantization tutorials such that
they can be run smoothly by the user.

Test Plan: Ran the updated tutorials without problem.

Reviewers: jerryzh168

Subscribers: jerryzh168, supriyar

ghstack-source-id: 196719d
Pull Request resolved: #1763
jcaip added a commit that referenced this pull request Sep 6, 2022
* Fix quantization tutorials (imports, syntax, and style)

Summary: This commit fixes the quantization tutorials such that
they can be run smoothly by the user.

Test Plan: Ran the updated tutorials without problem.

Reviewers: jerryzh168

Subscribers: jerryzh168, supriyar

ghstack-source-id: 196719d
Pull Request resolved: #1763

* Fix quantization tutorials (imports, syntax, and style)

Summary: This commit fixes the quantization tutorials such that
they can be run smoothly by the user.

Test Plan: Ran the updated tutorials without problem.

Reviewers: jerryzh168

Subscribers: jerryzh168, supriyar

ghstack-source-id: 196719d
Pull Request resolved: #1763

* revert paths for wikitext version

* Fix broken url

Co-authored-by: Jesse Cai <[email protected]>
Co-authored-by: Jesse Cai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants