Create ImageFolder with the same (sorted) order on different machines
#193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #192, current
make_datasetfunction forImageFoldermay create datasets with different orders becauseos.listdir(dir)might produce different results on different machines.This can be inconvenient if the user wants to compare or ensemble the outputs of the full dataset (for example, the validation set).
A simple modification
for target in sorted(os.listdir(dir)):solves the problem. And since the loading procedure itself can be shuffled, I have not found the possible problems can be caused by this modification.