Skip to content

shorten delete_splits_marked_for_deletion log #5395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

trinity-1686a
Copy link
Contributor

Description

make delete_splits_marked_for_deletion shorter. Before it used to show only a single index id, but with gc batching, it can now show thousands at once when that function returns an error.

Copy link

github-actions bot commented Sep 6, 2024

On SSD:

Average search latency is 0.991x that of the reference (lower is better).
Ref run id: 3290, ref commit: 6768d01
Link

On GCS:

Average search latency is 0.972x that of the reference (lower is better).
Ref run id: 3291, ref commit: 6768d01
Link

@trinity-1686a trinity-1686a enabled auto-merge (squash) September 6, 2024 13:15
@trinity-1686a trinity-1686a merged commit 79acfe4 into main Sep 6, 2024
5 checks passed
@trinity-1686a trinity-1686a deleted the trinity/shorten-log branch September 6, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants