Compress requests and responses for ingest v2 endpoints #5779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilload
force-pushed
the
guilload/ingest-v2-compression
branch
from
d4111fb to
37b08be
Compare
rdettai
reviewed
May 28, 2025
guilload
force-pushed
the
guilload/ingest-v2-compression
branch
from
ba71c84 to
a49cbc1
Compare
guilload
force-pushed
the
guilload/ingest-v2-compression
branch
from
a49cbc1 to
9a840f0
Compare
rdettai
approved these changes
May 29, 2025
There was a problem hiding this comment.
I think this feature is worth being documented. I can do it in a separate PR if you prefer. I would also add a small comment about the fact that it should be deployed with the compression disabled first in https://quickwit.io/docs/main-branch/operating/upgrades.
| #[derive(Clone, Debug, PartialEq, Serialize, Deserialize)] | ||
| #[serde(rename_all = "lowercase")] | ||
| pub enum CompressionAlgorithm { | ||
| Gzip, |
There was a problem hiding this comment.
out of curiosity, when would Gzip be a good choice?
There was a problem hiding this comment.
Probably never. Maybe if the network is crazy slow and/or expensive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Compress requests and responses for ingest v2 endpoints using builtin tonic compression.
How was this PR tested?
Added unit test