Cobertura coverage-04.dtd support

[samssann]

Modified 'coverage' xml node to include:

• lines-covered (number of lines where there were no hits)
• lines-valid (number of lines of code)
• branches-covered (covr does not calculate branching, set to 0)
• branches-valid (covr does not calculate branching, set to 0)
• complexity (covr does not calculate complexity, set to 0)

Further detail:

• Cobertura coverage-04.dtd support nedbat/coveragepy#570
• https://github.com/cobertura/web/tree/master/htdocs/xml

[CLAassistant]

All committers have signed the CLA.

[jimhester]

What happens if these fields exist and you run with earlier versions of cobertura? Are they ignored?

[samssann]

I was wondering that myself, but could not find a definitive answer so far. At least in coveragepy they've just added the new fields. Same applies to gcovr. We could of course implement

to_cobertura(cov, filename = "cobertura.xml", dtd = c("03,"04") {
  dtd <- match.arg(dtd)
  ... set fields according to dtd version ...
}

if you want to be sure. Or just ask cobertura about backwards compatibility.

[samssann]

@wligtenberg #197, any insight on backwards compatibility?

[wligtenberg]

I don't have anything that I can add. Unfortunately I do not have access to the Jenkins server I used to test this when i developed this feature.

[robertdj]

I have just implemented these additions myself (also on file and function level). They are needed for Azure DevOps to parse the Cobertura report.
Unfortunately, I cannot offer to test earlier versions, but I would love this feature here :-)

[jimhester]

@samssann can you add a note to NEWS.md mentioning this change, the issue number and your GitHub username, then I can merge this.

[jimhester]

Thanks!