Skip to content
This repository was archived by the owner on Nov 16, 2020. It is now read-only.

HTTP proxy settings are applied too late #5

Closed
lukebakken opened this issue Dec 12, 2017 · 2 comments
Closed

HTTP proxy settings are applied too late #5

lukebakken opened this issue Dec 12, 2017 · 2 comments
Assignees
@michaelklishin
Labels
bug
Milestone
3.7.1

Comments

@lukebakken
Copy link
Contributor

lukebakken commented Dec 12, 2017 •
edited by gerhard
Loading

rabbitmq-users > rabbitmq_peer_discovery_aws behind proxy

rabbitmq/rabbitmq-peer-discovery-aws#6 is keeping me from reproducing the issue on the mailing list. Basically, I think that the rabbit_peer_discovery_common_app module is starting after other modules that depend on it, since this line is what configures proxies
@lukebakken lukebakken added the bug label Dec 12, 2017
@gerhard gerhard modified the milestone: 3.7.1 Dec 13, 2017
@michaelklishin michaelklishin mentioned this issue Dec 13, 2017
Closed
@michaelklishin
Copy link
Contributor

In the original thread, the OP confirms that AWS peer discovery does work without the proxy settings. Therefore this issue is our working theory. Assuming it affects all HTTP client-based discovery plugins, I'm going to add extra debug logging and try to trace the sequence of operations with Consul or etcd.

@michaelklishin michaelklishin self-assigned this Dec 14, 2017
@michaelklishin
Copy link
Contributor

I have evidence that this is a valid issue. Now we have a chicken-and-egg problem with HTTP client settings: peer discovery happens very early on in boot process, before rabbitmq-peer-discovery-common is started. However, we cannot start it that early because it depends on rabbit which is in the process of being started. I'm investigating what options we may have.

michaelklishin added a commit to rabbitmq/rabbitmq-peer-discovery-etcd that referenced this issue Dec 14, 2017
@michaelklishin
Configure HTTP client proxy at init step
90c3c94 
Part of rabbitmq/rabbitmq-peer-discovery-common#5.

[#153615554]
michaelklishin added a commit to rabbitmq/rabbitmq-peer-discovery-consul that referenced this issue Dec 14, 2017
@michaelklishin
Configure HTTP client proxy at init step
7c34562 
Part of rabbitmq/rabbitmq-peer-discovery-common#5.

[#153615554]
michaelklishin added a commit to rabbitmq/rabbitmq-server that referenced this issue Dec 14, 2017
@michaelklishin
Add an optional init step for peer discovery mechanisms
e08895d 
Sometimes they need to perform some initialisation very early on,
e.g. to configure HTTP client proxy settings or similar.

Part of rabbitmq/rabbitmq-peer-discovery-common#5.

[#153615554]
michaelklishin added a commit to rabbitmq/rabbitmq-common that referenced this issue Dec 14, 2017
@michaelklishin
Peer discovery backend: add an optional init callback
9b4b327 
Part of rabbitmq/rabbitmq-peer-discovery-common#5.

[#153615554]
michaelklishin added a commit to rabbitmq/rabbitmq-peer-discovery-k8s that referenced this issue Dec 14, 2017
@michaelklishin
Configure HTTP client proxy at init step
07b7ac2 
Part of rabbitmq/rabbitmq-peer-discovery-common#5.

[#153615554]
This was referenced Dec 14, 2017
Merged
Merged
Merged
Merged
Merged
michaelklishin added a commit to rabbitmq/rabbitmq-peer-discovery-consul that referenced this issue Dec 14, 2017
@michaelklishin
Export init/0
0ca2ce9 
Part of rabbitmq/rabbitmq-peer-discovery-common#5.

[#153615554]
michaelklishin added a commit to rabbitmq/rabbitmq-peer-discovery-aws that referenced this issue Dec 14, 2017
@michaelklishin
Configure HTTP client proxy at init step
0864f8d 
Part of rabbitmq/rabbitmq-peer-discovery-common#5.

[#153615554]
@michaelklishin michaelklishin mentioned this issue Dec 14, 2017
Merged
@michaelklishin michaelklishin added this to the 3.7.1 milestone Dec 14, 2017
michaelklishin added a commit to rabbitmq/rabbitmq-common that referenced this issue Dec 15, 2017
@michaelklishin
Peer discovery backend: add an optional init callback
54d0a7c 
Part of rabbitmq/rabbitmq-peer-discovery-common#5.

[#153615554]

(cherry picked from commit 9b4b327)
michaelklishin added a commit to rabbitmq/rabbitmq-server that referenced this issue Dec 15, 2017
@michaelklishin
Add an optional init step for peer discovery mechanisms
d049862 
Sometimes they need to perform some initialisation very early on,
e.g. to configure HTTP client proxy settings or similar.

Part of rabbitmq/rabbitmq-peer-discovery-common#5.

[#153615554]

(cherry picked from commit e08895d)
michaelklishin added a commit to rabbitmq/rabbitmq-peer-discovery-consul that referenced this issue Dec 15, 2017
@michaelklishin
Configure HTTP client proxy at init step
26ce295 
Part of rabbitmq/rabbitmq-peer-discovery-common#5.

[#153615554]

(cherry picked from commit 7c34562)
michaelklishin added a commit to rabbitmq/rabbitmq-peer-discovery-consul that referenced this issue Dec 15, 2017
@michaelklishin
Export init/0
e9e1a1d 
Part of rabbitmq/rabbitmq-peer-discovery-common#5.

[#153615554]

(cherry picked from commit 0ca2ce9)
michaelklishin added a commit to rabbitmq/rabbitmq-peer-discovery-etcd that referenced this issue Dec 15, 2017
@michaelklishin
Configure HTTP client proxy at init step
99041a3 
Part of rabbitmq/rabbitmq-peer-discovery-common#5.

[#153615554]

(cherry picked from commit 90c3c94)
michaelklishin added a commit to rabbitmq/rabbitmq-peer-discovery-k8s that referenced this issue Dec 15, 2017
@michaelklishin
Configure HTTP client proxy at init step
60a5fcc 
Part of rabbitmq/rabbitmq-peer-discovery-common#5.

[#153615554]

(cherry picked from commit 07b7ac2)
michaelklishin added a commit to rabbitmq/rabbitmq-peer-discovery-aws that referenced this issue Dec 15, 2017
@michaelklishin
Configure HTTP client proxy at init step
1105286 
Part of rabbitmq/rabbitmq-peer-discovery-common#5.

[#153615554]

(cherry picked from commit 0864f8d)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@michaelklishin michaelklishin

Labels
bug
Projects
None yet
Milestone
3.7.1
Development

No branches or pull requests
3 participants
@michaelklishin @gerhard @lukebakken