Skip to content

rabbit_feature_flags: Trap exit signal in the controller (backport #10279) #10280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jan 4, 2024

This is an automatic backport of pull request #10279 done by Mergify.
Cherry-pick of a472982 has failed:

On branch mergify/bp/v3.12.x/pr-10279
Your branch is up to date with 'origin/v3.12.x'.

You are currently cherry-picking commit a472982d26.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   deps/rabbit/src/rabbit_ff_controller.erl

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@mergify mergify bot added the conflicts label Jan 4, 2024
@michaelklishin michaelklishin added this to the 3.12.12 milestone Jan 4, 2024
@dumbbell dumbbell marked this pull request as draft January 4, 2024 15:30
[Why]
We need to do this for the `terminate/3` to be called. Without this, the
process exits without calling it.

(cherry picked from commit a472982)
@dumbbell dumbbell force-pushed the mergify/bp/v3.12.x/pr-10279 branch from 7371b0f to 0723018 Compare January 4, 2024 15:32
@michaelklishin michaelklishin removed this from the 3.12.12 milestone Jan 4, 2024
@dumbbell dumbbell marked this pull request as ready for review January 4, 2024 17:11
@dumbbell dumbbell removed the conflicts label Jan 4, 2024
@dumbbell dumbbell merged commit e821aeb into v3.12.x Jan 4, 2024
@dumbbell dumbbell deleted the mergify/bp/v3.12.x/pr-10279 branch January 4, 2024 17:11
@michaelklishin michaelklishin added this to the 3.12.12 milestone Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants