-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Support file extension in the RABBITMQ_CONFIG_FILE env var values #711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This breaks support for paths without a filename extension. The problematic line seems to be
|
Otherwise if there is no dot in RABBITMQ_CONFIG_FILE, RABBITMQ_CONFIG_FILE_NOEX ends up being empty.
Or we can just change conditions, because extension is being checked there anyway. So we can use any extension trimming mechanism. |
@hairyhum this passes the acceptance criteria for |
Added support for |
This looks good on OS X (zsh) and Ubuntu (dash). Haven't had a chance to test on Windows yet. |
) else ( | ||
if exist "!RABBITMQ_CONFIG_FILE!.config" ( | ||
set RABBITMQ_CONFIG_ARG=-config "!RABBITMQ_CONFIG_FILE!" | ||
) else if exist "!RABBITMQ_CONFIG_FILE!.config" ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this else if
should be else if exist "!RABBITMQ_CONFIG_FILE!.conf"
as rabbitmq-server.bat
Fixes #691