Skip to content

fix(filter): Interpolation for arg-based fields #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rabbitstack merged 1 commit into from
Mar 19, 2025
Merged

fix(filter): Interpolation for arg-based fields #462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion pkg/filter/filter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,18 @@ func InterpolateFields(s string, evts []*kevent.Kevent) string {
if len(matches) == 0 {
return s
}

split := func(s string) (string, string) {
n, m := strings.Index(s, "["), strings.Index(s, "]")
if n < 0 || m < 0 {
return s, ""
}
if n > m {
return s, ""
}
return s[0:n], s[n+1 : m]
}

for _, m := range matches {
switch {
case len(m) == 3:
Expand All @@ -376,8 +388,9 @@ func InterpolateFields(s string, evts []*kevent.Kevent) string {
// extract field value from the event and replace in string
var val any
for _, accessor := range GetAccessors() {
name, arg := split(m[2])
f := Field{Value: m[2], Name: fields.Field(name), Arg: arg}
var err error
f := Field{Value: m[2], Name: fields.Field(m[2])}
val, err = accessor.Get(f, kevt)
if err != nil {
continue
Expand Down
7 changes: 5 additions & 2 deletions pkg/filter/filter_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1228,8 +1228,8 @@ func TestInterpolateFields(t *testing.T) {
evts []*kevent.Kevent
}{
{
original: "Credential discovery via %ps.name and user %ps.sid",
interpolated: "Credential discovery via VaultCmd.exe and user LOCAL\\tor",
original: "Credential discovery via %ps.name (%kevt.arg[cmdline]) and user %ps.sid",
interpolated: "Credential discovery via VaultCmd.exe (VaultCmd.exe /listcreds:Windows Credentials /all) and user LOCAL\\tor",
evts: []*kevent.Kevent{
{
Type: ktypes.CreateProcess,
Expand All @@ -1241,6 +1241,9 @@ func TestInterpolateFields(t *testing.T) {
Ppid: 345,
SID: "LOCAL\\tor",
},
Kparams: kevent.Kparams{
kparams.Cmdline: {Name: kparams.Cmdline, Type: kparams.UnicodeString, Value: `VaultCmd.exe /listcreds:Windows Credentials /all`},
},
},
},
},
Expand Down