-
Notifications
You must be signed in to change notification settings - Fork 796
Add support for JRuby 9000 dev bundled with the Graal VM. #514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bin/ruby-build
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there no way to reuse build_package_jruby somehow? Maybe invoke it from here with an optional argument that cancels out install_jruby_launcher?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes of course - good idea.
|
This could use tests. Also, not sure how I feel about maintaining this. What do others think? I can't tell how valuable would this be to the JRuby community |
|
I can guarantee I'll deal with any maintenance issues that come up if you ping me. I will also look at some tests - might take me a couple of days as I'm not used your test system. I know it's not immediately useful to many people, but we're trying to promote a whole new way of doing dynamic languages on the JVM. There's huge potential here and we're working with JRuby to make it actually useful, rather than just a research project. Being in rbenv will massively lower the barrier to entry for people who want to experiment. |
|
I'm but a single voice, but I would find this very helpful. As a JRuby user, the future direction of JRuby is very important to me. But I admit that setting up Graal has thus far been a hurdle I've not wanted to dedicate any time to. Having a simple installation option and the ability to switch to it with rbenv would be fantastic. |
|
Truffle has a lot of developer interest and a lot of effort being put into it. I suspect people will want to try their stuff using this backend more and more as time goes on (some earlier benches look very promising). It is unclear where Truffle fits into our long term picture for JRuby but things are moving pretty quickly for the Truffle folks and having a simple way to try out the JRuby truffle backend might help them garner more interest in it. We are happy enough with the idea that they are committing directly to our repo... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why require java7 if the package bundles its own java?
|
Alright then. Address my comments and we'll merge it |
|
I've fixed the Java 7 requirement, switched to conform to your style, changed the launcher thing to detect whether it should install or not based on the presence of Graal, and added tests. |
|
The test was broken, so I re-did it. Otherwise, everything was great; thanks. |
|
Great, I've been waiting for it since I read a blog post by @Hedius. |
JRuby 9000 (the next major release) includes a backend that supports a new JVM JIT compiler called Graal. Graal is based on OpenJDK but hasn't been released yet. This patch allows you to download Graal with JRuby and have JRuby already configured to use it instead of your system Java.
http://openjdk.java.net/projects/graal/
I know this is a bit niche, but I promise to keep it updated, and remove it if it's not longer applicable.