Skip to content

Conversation

@josepot
Copy link
Member

@josepot josepot commented Apr 4, 2022

useStateObservable was not taking into account the Context subscription 🙈

@josepot josepot requested a review from voliva April 4, 2022 15:24
@josepot josepot force-pushed the fix/useStateObservable branch from 4bc8fb9 to bb2c359 Compare April 4, 2022 15:25
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #253 (bb2c359) into main (6fe91f8) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #253   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        24    -1     
  Lines          370       361    -9     
  Branches        52        50    -2     
=========================================
- Hits           370       361    -9     
Impacted Files Coverage Δ
packages/core/src/Subscribe.tsx 100.00% <100.00%> (ø)
packages/core/src/bind/connectFactoryObservable.ts 100.00% <100.00%> (ø)
packages/core/src/bind/connectObservable.ts 100.00% <100.00%> (ø)
packages/core/src/useStateObservable.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fe91f8...bb2c359. Read the comment docs.

@josepot josepot merged commit 1af9c62 into main Apr 4, 2022
@josepot josepot deleted the fix/useStateObservable branch April 4, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants