Skip to content

Align tsconfig.json with TypeScript 4.4+ #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2022

Conversation

friederbluemle
Copy link
Contributor

This aligns tsconfig.json with the default as generated by tsc --init (using TypeScript 4.6.4).

TypeScript has updated the format (mainly ordering and documentation) of tsconfig.json starting with TypeScript 4.4

While there are many line changes, there are zero configuration changes: The values for target, module, lib, etc. remain the same - Any potential future updates should be done in a separate PR, not mixed with a (primarily) visual formatting change.

The only new option added (which TS now includes by default), is "forceConsistentCasingInFileNames": true, which I think is good to have.

Adding a // prettier-ignore comment at line 1 of the file ensures Prettier does not accidentally reformat the whole file, resulting in misalignment of documentation comments on non-commented lines only.

Copy link
Member

@emin93 emin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are great changes, thanks!

@emin93 emin93 merged commit 0ec809b into react-native-community:main May 18, 2022
@friederbluemle friederbluemle deleted the tsconfig branch May 18, 2022 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants