[FEATURE]: Added Android overscroll property #54
Conversation
|
Should this be unified with https://facebook.github.io/react-native/docs/webview#bounces? |
js/WebView.android.js
Outdated
| */ | ||
| class WebView extends React.Component<WebViewSharedProps, State> { | ||
| static defaultProps = { | ||
| overScrollMode: 0, |
There was a problem hiding this comment.
Let's add some constants for these modes:
OVER_SCROLL_ALWAYS = 0
OVER_SCROLL_CONTENT = 1
OVER_SCROLL_NEVER = 2
So then this would be something like
static OVER_SCROLL_ALWAYS = 0
static OVER_SCROLL_CONTENT = 1
static OVER_SCROLL_NEVER = 2
static defaultProps = {
overScrollMode: OVER_SCROLL_ALWAYS,
// ...There was a problem hiding this comment.
Do you want to expose thoses values to the user ? or are you just trying to make the internal code clearer?
There was a problem hiding this comment.
Good question -- I feel we need them either way, but exposing to the user seems like a good idea. Your thoughts?
There was a problem hiding this comment.
What if it was changed to use a string, rather than a number? Like:
overScrollMode?: 'always' | 'content' | 'never',And on the android side, it converted the strings back to their appropriate numbers
There was a problem hiding this comment.
I really like that idea @empyrical, and it would fit with some other properties, like this one:
js/WebViewTypes.js
Outdated
| * 2 = never | ||
| * @platform android | ||
| */ | ||
| overScrollMode?: ?number, |
There was a problem hiding this comment.
Actually - perhaps this would be better:
overScrollMode?: ?(0 | 1 | 2),
Titozzz
changed the title
|
Updated to string, WDYT? |
| */ | ||
| class WebView extends React.Component<WebViewSharedProps, State> { | ||
| static defaultProps = { | ||
| overScrollMode: 'always', |
There was a problem hiding this comment.
Maybe content makes more sense as default? It's basically 'auto'.
There was a problem hiding this comment.
Well android default is always, I think we should not alter the current behavior
|
@Titozzz Can you add a note in the API reference in |
|
Will sure do |
Titozzz
changed the title
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
This job, okay? overscroll feature is not working |
No description provided.