Fix: Restore case-insensitive WireUpControls feature #2080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reintroduce the controlIds dictionary to allow for case-insensitive resource IDs. - Map assesmbly to dictionary of resource IDs and load the assembly lazily, as needed. - Replace generic GetControl extensions with non-generic versions (gets rid of multiple casts). - Get rid of the reflection method members. - Add conditional for support fragment via the RXUI_ANDROID_SUPPORT constant.
- Lazily determine assembly of the type making the call to WireUpControls. - Use a ConcurrentDictionary to map assembly to the controlIds dictionary. - Get rid of unneeded GetControl Fragment overload.
Only the support fragment overload is needed because we're sharing the base code.
…o fix/android-wireupcontrols
| private static readonly ConditionalWeakTable<object, Dictionary<string, View>> viewCache = | ||
| new ConditionalWeakTable<object, Dictionary<string, View>>(); | ||
|
|
||
| static ControlFetcherMixin() |
There was a problem hiding this comment.
Do we need the empty constructor?
There was a problem hiding this comment.
No, I can remove it.
glennawatson
approved these changes
Jun 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes #2061
What is the current behavior?
Not wiring up controls that are camel cased in the axml, but are upper cased in the class. If the axml is changed to match the class, it wires up.
What is the new behavior?
Wiring up controls won't depend on property case.
What might this PR break?
Anyone calling the View overload of GetControl because the signature changed.
Anyone calling the Fragment overload of GetControl because it was removed.
Please check if the PR fulfills these requirements
Other information: