Dynamically append path alias (aaa/bbb.html = aaa/bbb = aaa/bbb/) int… #783
Conversation
…o redirects during gatsby onCreateNode callback API to avoid 404
|
Deploy preview for reactjs ready! Built with commit eed1eaa |
(1) markdown without redirects (2) duplicated permalink for /docs/pure-render-mixin.html, rename the unused one
gatsby/onCreateNode.js
Outdated
| @@ -9,6 +9,22 @@ | |||
| // Parse date information out of blog post filename. | |||
| const BLOG_POST_FILENAME_REGEX = /([0-9]+)\-([0-9]+)\-([0-9]+)\-(.+)\.md$/; | |||
|
|
|||
| function buildRedirectString(permalink, redirect_from) { | |||
| if (!permalink || permalink.indexOf('.html') === -1) { | |||
There was a problem hiding this comment.
Instead of indexOf, can we do !permalink.endsWith('.html') so it won't catch if there is .html elsewhere in the name?
There was a problem hiding this comment.
Note: endsWith() isn't supported by IE unless we polyfill it
There was a problem hiding this comment.
I sorta assumed this runs at build time. If not, !/\.html$/.test(permalink) would work.
There was a problem hiding this comment.
Thanks, will do that!
gatsby/onCreateNode.js
Outdated
| return ''; | ||
| } | ||
|
|
||
| let basePath = permalink.slice(0, permalink.indexOf('.html')); |
gatsby/onCreateNode.js
Outdated
| @@ -9,6 +9,22 @@ | |||
| // Parse date information out of blog post filename. | |||
| const BLOG_POST_FILENAME_REGEX = /([0-9]+)\-([0-9]+)\-([0-9]+)\-(.+)\.md$/; | |||
|
|
|||
| function buildRedirectString(permalink, redirect_from) { | |||
| if (!permalink || permalink.indexOf('.html') === -1) { | |||
| return ''; | |||
There was a problem hiding this comment.
Should return redirect_from.
gatsby/onCreateNode.js
Outdated
| let redirects = [basePath, basePath + '/']; | ||
| if (Array.isArray(redirect_from)) { | ||
| redirects = redirects.concat(redirect_from); | ||
| //} else if (redirect_from) { |
There was a problem hiding this comment.
remove these commented lines
| @@ -3,7 +3,7 @@ id: pure-render-mixin | |||
| title: PureRenderMixin | |||
| layout: docs | |||
| category: Reference | |||
| permalink: docs/pure-render-mixin.html | |||
| permalink: docs/pure-render-mixin-old.html | |||
There was a problem hiding this comment.
Is this file ever accessible? If not let's just delete it.
|
@sophiebits Thanks for the solid review! I have learned something from them. I follow most of your suggestions, with some minor differences listed below:
Thanks! |
|
Hi, @sophiebits just want to know if I should further update this PR? Looks like this issue is still there. (sorry for poking, I know you guys are definitely busy) Thanks! |
This PR tries to fix #605
The issue is following 404 pages, such as:
https://reactjs.org/docs/hello-worldhttps://reactjs.org/docs/hello-world/As we can see, only https://reactjs.org/docs/hello-world.html can work correctly. The common alias we consider the same as it won't work.
The brute force approach for this issue might be simply modifying all *.md files for the
redirect_fromto include the alias paths. However, I think a better approach will be to append those alias path dynamically during gatsby'sonCreateNodeAPI.