Skip to content

Update to SDK 35 #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 4, 2024
Merged

Update to SDK 35 #575

merged 9 commits into from
Nov 4, 2024

Conversation

stevenzeck
Copy link
Contributor

No description provided.

Copy link
Member

@mickael-menu mickael-menu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stevenzeck. We'll have to monitor any issue related to edge-to-edge.

@stevenzeck
Copy link
Contributor Author

stevenzeck commented Nov 1, 2024

It looks like an update to AppCompat is required for edge-to-edge and insets to work properly on API 35 with the original changes. Best for #576 to be merged first.

Edit: Also since androidx core 1.15.0 requires API level 35, 576 also needs to be merged first since it has the testapp change to use gradle.properties.

Copy link
Member

@mickael-menu mickael-menu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that solved the issues I had 👌

@mickael-menu mickael-menu merged commit dfb76bc into readium:develop Nov 4, 2024
3 checks passed
@mickael-menu mickael-menu deleted the sdk-35 branch November 4, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants