fix: webpub EPUBs #642
Merged
fix: webpub EPUBs #642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickael-menu
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #641
Unlike swift-toolkit, this one did not set the correct
positionsServiceFactoryfor WebPubs which conform to EPUB (regular EPUBs packaged as WebPub).See https://github.com/readium/swift-toolkit/blob/develop/Sources/Streamer/Parser/Readium/ReadiumWebPubParser.swift#L108-L109
There also seemed to be an issue with FXL being the default layout, if none set via metadata.presentation. This does not seem to be the case with other toolkits and broke CSS/JS injections for our WebPubs. @mickael-menu maybe there is a smarter way to fix this?