Skip to content

Conversation

@vpzee
Copy link

@vpzee vpzee commented Feb 28, 2015

No description provided.

@sigmavirus24
Copy link
Contributor

Please use http://docs.python-guide.org/en/latest/notes/contribute.html instead of the readthedocs.org URL.

@vpzee
Copy link
Author

vpzee commented Feb 28, 2015

Thanks for the correct URL.

@sigmavirus24
Copy link
Contributor

It's not worth my being a stickler about this time but in the future @vpzee please do not make various other formatting changes in a pull request that has nothing to do with them.

Thanks for fixing this link! 🍰

sigmavirus24 added a commit that referenced this pull request Feb 28, 2015
Fixing the urls pointing to the contribute page
@sigmavirus24 sigmavirus24 merged commit fd8572a into realpython:master Feb 28, 2015
@vpzee
Copy link
Author

vpzee commented Feb 28, 2015

This was my first contribution ever. I can use every guidance I can get to be a good citizen here.
Thank you.

@sigmavirus24
Copy link
Contributor

Congrats @vpzee! To be as explicit as possible: if you're fixing a bug in a project, just fix the bug. Don't fix anything else in that pull request unless the project owner or maintainer ask you to. It makes reviewing the changes/fixes much easier for us and will improve your pull request's chances of being merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants