Skip to content

Misc infra fixes (phpstan, gha) #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 6, 2023
Merged

Misc infra fixes (phpstan, gha) #962

merged 4 commits into from
Jan 6, 2023

Conversation

mfn
Copy link
Collaborator

@mfn mfn commented Jan 6, 2023

Summary

It's time to update the misc infrastructure things to avoid noisy errors and broken builds on invalid combinations:

  • silence a few newly popped up errors in phpstan
  • ignore L6 on PHP 8.2 too

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist:

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

mfn added 4 commits January 6, 2023 10:27
@mfn
phpstan: silence "Cannot call method make() on Illuminate\Foundation\…
6550a8a 
…Application|null."
@mfn
phpstan: silence "Offset 'config' does not exist on Illuminate\Founda…
b967b8b 
…tion\Application|null."
@mfn
phpstan: silence "Parameter #1 $laravel of method Illuminate\Console\…
11bf248 
…Command::setLaravel() expects Illuminate\Contracts\Container\Container, Illuminate\Foundation\Application|null given"
@mfn
gha: ignore L6 on PHP 8.2 as well
e4f42ba
@mfn mfn self-assigned this Jan 6, 2023
@mfn mfn marked this pull request as draft January 6, 2023 09:41
@mfn mfn marked this pull request as ready for review January 6, 2023 09:43
@mfn mfn changed the title Misc infra fixes (phpstsan, gha) Misc infra fixes (phpstan, gha) Jan 6, 2023
@mfn mfn merged commit 1495a15 into master Jan 6, 2023
@mfn mfn deleted the mp-misc-fixes branch January 6, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mfn mfn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mfn