Fix terminateSubscription params

[geoffdutton]

I was trying to terminate a subscription with a full refund and figured out that the params arg was not being passed to _makeRequest. I've verified this fixes it.

Writing the test was probably overkill, but at least it won't come up again now. ;)

[douglasmiller]

Hi @geoffdutton,

Thank you for bringing this to our attention and taking the time to address the issue yourself. Some components of the client libraries are generated by a proprietary application that takes the openapi specification as input. Unfortunately, the Client.js file is one of these generated files (you may have missed the comment at the top since the file is very large).

We will take a look into why the code generation process isn't properly passing the params object into the _makeRequest method and keep you updated.

[geoffdutton]

Got it, hence why no tests and the ignore comment at the top.

Edit: Perhaps it's the DELETE method? It doesn't look like any of the other DELETE methods have a params arg.

Double Edit: OAI/OpenAPI-Specification#1801

[douglasmiller]

@geoffdutton I've found the issue in the generator. Apparently, it was not passing the optional params object into the _makeRequest method for any of the operations.

I've opened #95 to fix these issues and will publish a new client version soon after it is merged.

[douglasmiller]

@geoffdutton The 3.5.1 version of the node library has been published with the updates: https://www.npmjs.com/package/recurly/v/3.5.1