-
Notifications
You must be signed in to change notification settings - Fork 227
K8s: private images - mention admission controller #1791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwdougherty
approved these changes
Jul 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
dwdougherty
added a commit
that referenced
this pull request
Jul 7, 2025
* Improve rack-awareness documentation for Kubernetes - Add clear explanation of node labeling requirements for rack-awareness - Emphasize that ALL eligible nodes must be labeled with chosen label - Explain what eligible nodes are (nodes where RS pods can be scheduled) - Suggest topology.kubernetes.io/zone as commonly available label - Clarify that not all platforms have this label by default - Update example to use current topology.kubernetes.io/zone instead of deprecated failure-domain.beta.kubernetes.io/zone - Fix kubectl command formatting (add space after $) - Add warning about operator failing if nodes are missing labels Addresses DOC-1815 * Update content/operate/kubernetes/recommendations/node-selection.md Co-authored-by: Kaitlyn Michael <[email protected]> * Update content/operate/kubernetes/recommendations/node-selection.md Co-authored-by: Kaitlyn Michael <[email protected]> * Update content/operate/kubernetes/recommendations/node-selection.md Co-authored-by: Kaitlyn Michael <[email protected]> * Update content/operate/kubernetes/recommendations/node-selection.md Co-authored-by: Kaitlyn Michael <[email protected]> * Update content/operate/kubernetes/recommendations/node-selection.md Co-authored-by: Kaitlyn Michael <[email protected]> * Move redisvl documentation * Remove type integration * Add redisvl/_index.md * Fix relrefs * Add aliases * Add missing aliases * DOC-3967 moved/expanded keyspace page * DOC-3967 fixed links to keyspace page * DOC-3967 moved transaction and pipeline pages to reference section * DOC-3967 moved patterns folder to clients * DOC-3967 moved programmability folder into develop * DOC-3967 fixed links to programmability section * DOC-3967 added aliases to programmability pages * DOC-3967 moved pub/sub and keyspace notification pages * DOC-3967 added missing aliases * RDI: Add Reboot step after parameter group step * add link icon to section headers (#1755) * add link icon to section headers * review suggestions * toc embed fix * Attempt to fix the broken on this page ToC for embedded content that includes headers --------- Co-authored-by: Rachel Elledge <[email protected]> * mention admission controller (#1791) * relref fix (#1793) * Update content/operate/rc/api/api-reference/openapi.json * fix typo (#1795) * DOC-5419 added commands section * DOC-5419 fixed dodgy link * RS: Adjusted best practices for scalable Redis query engine & add benchmarks (#1687) * DOC-4271 RS: Adjusted best practices for scalable Redis query engine & add benchmarks * Style guide fix for indexes * Fixed broken relrefs after AI/search reorg * RS: Added missing module requirements to recover DB (#1679) * DOC-4564 RS: Added missing module requirements to recover DB * DOC-4564 Added rladmin command to identify module versions required by recoverable DBs * DOC-4564 Copied missing module requirements to recover DB to RS 7.4 and 7.8 versions * RS: Added DB port access requirement for Replica Of between different RS clusters (#1650) * DOC-3829 RS: Added DB port access requirement for Replica Of between different RS clusters * Updated relrefs to correct versions * Update ai-videos.md * Fix search-and-query documentation aliases for backward compatibility ## Critical alias fixes to resolve 404 errors and incorrect redirects: ### Fixed broken basic-constructs aliases: - field-and-type-options.md: Fixed alias to point to correct interact paths - schema-definition.md: Fixed alias to point to correct interact paths - configuration.md: Added missing interact aliases and fixed format ### Fixed directory redirect issues (_index.md files): - Added trailing slash variants for all directory aliases - Fixed indexing/ and query/ URLs that were redirecting to home page - Updated: _index.md, indexing/_index.md, query/_index.md, advanced-concepts/_index.md, administration/_index.md, best-practices/_index.md, deprecated/_index.md ### Added missing aliases: - index-mgmt-best-practices.md: Added missing interact alias - aggregations-syntax.md: Added missing interact alias ### Root causes addressed: - Aliases were incorrectly pointing to /ai/ paths instead of /interact/ paths - Directory aliases needed both with/without trailing slash variants - Some files missing interact aliases entirely These fixes should resolve: - 404 errors on basic-constructs URLs - Directory URLs redirecting to home page instead of correct AI locations - Missing backward compatibility for moved files Addresses DOC-5428 * Update redisvl workflow (#1802) * DEV: (RediSearch) doc expiration capabilities in Redis 8 (#1792) * DEV: (RediSearch) doc expiration capabilities in Redis 8 * Apply suggestions from code review Co-authored-by: andy-stark-redis <[email protected]> * Apply more suggestions from code review --------- Co-authored-by: andy-stark-redis <[email protected]> * add leading slash to alias (#1804) * DOC-5423: update the modules API page --------- Co-authored-by: mich-elle-luna <[email protected]> Co-authored-by: mich-elle-luna <[email protected]> Co-authored-by: Kaitlyn Michael <[email protected]> Co-authored-by: paoloredis <[email protected]> Co-authored-by: Andy Stark <[email protected]> Co-authored-by: Cameron Bates <[email protected]> Co-authored-by: Rachel Elledge <[email protected]> Co-authored-by: redisdocsapp[bot] <177626021+redisdocsapp[bot]@users.noreply.github.com> Co-authored-by: andy-stark-redis <[email protected]> Co-authored-by: JooYoung Lim <[email protected]> Co-authored-by: Cameron Bates <[email protected]> Co-authored-by: Rachel Elledge <[email protected]> Co-authored-by: paoloredis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOC-1509