Skip to content

support "XINFO CONSUMERS" #1649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 9, 2021
Merged

support "XINFO CONSUMERS" #1649

merged 2 commits into from
Feb 9, 2021

Conversation

kkkbird
Copy link
Contributor

@kkkbird kkkbird commented Feb 3, 2021

add function "XInfoConsumers" as "XInfoGroups", tested on redis 6.0.10

btw: refer to xinfo document, these codes may not workable in future redis release

Note that you should not rely on the fields exact position, nor on the number of fields, new fields may be added in the future. So a well behaving client should fetch the whole list, and report it to the user, for example, as a dictionary data structure. Low level clients such as C clients where the items will likely be reported back in a linear array should document that the order is undefined.

@vmihailenco
Copy link
Collaborator

@kkkbird thanks for the contribution - code looks good. Is it possible to add a test?

@kkkbird
Copy link
Contributor Author

kkkbird commented Feb 5, 2021

test is added

@vmihailenco
Copy link
Collaborator

@kkkbird thank you 👍

@vmihailenco vmihailenco merged commit f594401 into redis:master Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants