Noting in documentation when client.duplicate() might be used #1031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly pointing out that when blocking and non-blocking functions are used on the same connection, unexpected results can occur
BrianRossmajer
changed the title
|
@BrianRossmajer this looks mainly good but I don't like to provide negative examples. Would you be so kind and rewrite the example accordingly? |
|
Ping @BrianRossmajer |
|
Hi Ruben, Sorry for the delay; I intend to do this but haven't had time. Should be Thanks, On Mon, Apr 18, 2016 at 3:50 PM, Ruben Bridgewater <[email protected]
|
Removing the negative example
Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly pointing out that when blocking and non-blocking functions are used on the same connection, unexpected results can occur