Skip to content

param socket_keepalive to set keep-alive on socket #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2014

Conversation

mohit
Copy link
Contributor

@mohit mohit commented Mar 25, 2014

Provide an option to enable setKeepAlive on the node TCP Socket for long running connections. This is a better option than pinging manually as mentioned in #530 and #247

@mohit
Copy link
Contributor Author

mohit commented Mar 25, 2014

The default should probably be true but is kept false to ensure that socket behavior is the same as previous versions unless explicitly changed.

@pesho
Copy link

pesho commented Apr 21, 2014

+1. I've encountered the same situation (long subscribe connections becoming unreachable, without the client noticing). It can happen when a connection sits idle for a long period. This looks like the best solution so far.

@ghost
Copy link

ghost commented Jul 8, 2014

👍 This is probably the right solution.
I was just about to implement it by myself.

http://www.tldp.org/HOWTO/html_single/TCP-Keepalive-HOWTO/

@brycebaril
Copy link
Contributor

Will be in the next version. I've also wanted this for a while.

I would much rather have this default to true than false given it should fix a number of other issues, and I can't think of any particular reason it would break backwards compatibility.

Thoughts?

@brycebaril
Copy link
Contributor

Released in v0.11.0 -- With the default set to true because I was already bumping the minor version anyway. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants