-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix regression, bring back socket support, fixes #950 #951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Before this PR on master on my MBP (I don't know if master was stable or not):
after this PR:
no regression were introduced @BridgeAR. I will add some tests tomorrow morning :) |
…g-reference, fixing it
@BridgeAR https://coveralls.io/builds/4677286/source?filename=index.js#L1302 is not tested, but I will wait for your feedback. Should I implement |
Hello @BridgeAR, any news on this? :) Do you want me to remove |
@FGRibreau I'm really busy right now and I guess I won't find time before next monday :/ If you attend the FOSDEM we could meet there though. |
Hello @BridgeAR, This PR is too old so I will need to rebase, can you confirm you will be able to merge it then? I will only keep the constructor and remove the non-existing |
@@ -33,9 +33,21 @@ function handle_detect_buffers_reply (reply, command, buffer_args) { | |||
|
|||
exports.debug_mode = /\bredis\b/i.test(process.env.NODE_DEBUG); | |||
|
|||
function RedisClient (options) { | |||
function RedisClient (globalOptions) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
function RedisClient (options, socket) {
Fix regression, bring back socket support, fixes #950