-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Wrong type annotation on fcall methods #3536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hey, thanks for reaching us out! Fix will be soon, but it will go to next major release due to API changes |
* Fixing typing for FCALL commands to match PEP 484 * Codestyle fixes * Fixes issue #3536
Thanks for the quick fix. Just searching through that file, I find the following other functions which may have similar problems:
These have the same problem, but I'm not sure if it's actually incorrect, due to them using the list_or_args helper which I'm not sure how it's used:
These have the same problem, but it may not matter as much because I assume they're internal:
|
The argument signature for the fcall methods reads:
Per PEP 484, the type annotation for an argument list should be the type of the expected elements, not
List
. This causes mypy to return spurious errors on code including the fcall method.I believe this annotation should be
*keys_and_args: Any
.The text was updated successfully, but these errors were encountered: