Skip to content

Update build tooling for 5.0 #4623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 23, 2023
Merged

Update build tooling for 5.0 #4623

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1437fcf
Bump build tooling versions
markerikson Nov 23, 2023
c2abb27
Use Node 18 in tests and update TS targets
markerikson Nov 23, 2023
9501bc4
Add missing error message
markerikson Nov 23, 2023
c609eb7
Reformat typetests to handle mismatched TS 4.x/5.x error locations
markerikson Nov 23, 2023
2b7af71
Use actual attw CLI and handle Node18 + CRA4
markerikson Nov 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use Node 18 in tests and update TS targets
  • Loading branch information
@markerikson
markerikson committed Nov 23, 2023
commit c2abb27cbe9db320da81fcfde34dfe1a7b508ee6
10 changes: 5 additions & 5 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: ['16.x']
node: ['18.x']

steps:
- name: Checkout repo
Expand Down Expand Up @@ -62,7 +62,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: ['16.x']
node: ['18.x']
steps:
- name: Checkout repo
uses: actions/checkout@v2
Expand Down Expand Up @@ -99,8 +99,8 @@ jobs:
strategy:
fail-fast: false
matrix:
node: ['16.x']
ts: ['4.7', '4.8', '4.9', '5.0']
node: ['18.x']
ts: ['4.7', '4.8', '4.9', '5.0', '5.1', '5.2', '5.3']
steps:
- name: Checkout repo
uses: actions/checkout@v2
Expand Down Expand Up @@ -140,7 +140,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: ['16.x']
node: ['18.x']
example:
[
'cra4',
Expand Down
2 changes: 1 addition & 1 deletion netlify.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
ignore = "git diff --quiet HEAD^ HEAD -- ../docs/ ."

[build.environment]
NODE_VERSION = "16.14.0"
NODE_VERSION = "18.15.0"
NODE_OPTIONS = "--max_old_space_size=4096"
NETLIFY_USE_YARN = "true"
YARN_VERSION = "1.22.10"
Expand Down