-
-
Notifications
You must be signed in to change notification settings - Fork 15.2k
updates for eslint cleanup #618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -17,7 +17,7 @@ function verifyStateShape(initialState, currentState) { | |||
var reducerKeys = Object.keys(currentState); | |||
|
|||
if (reducerKeys.length === 0) { | |||
console.error( | |||
console.error( // eslint-disable-line no-console |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe just disable the no-console
rule?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could if needed elsewhere. just the three lines needed it in one file. but do agree, this is source.. not examples
Is linting no longer running as part of Travis build? Why did we not see these lint errors? |
I looked at history of .travis.yml, don't believe linting was ever part of it? |
Lol, maybe so. Would you mind adding it? |
Might want to update to eslint 1.2.1 and babel-eslint to 4.0.10 as well (although that could be another PR)? |
@hzoo If you would like to submit a separate PR updating them, please feel free to! I haven't used |
How about @hzoo adds lint to Travis with that PR. I am getting an error running "npm run lint" under windows, even for the master branch. |
n/a to this PR |
Successful linting in Travis CI :) |
@hzoo I also have changes ready to go with the following npm updates: If you are not working on a PR for it, I will submit. Let me know! |
I haven't started it yet so go ahead! |
Notes: Minor changes to code in async, real-world examples to clear the eslint errors.