Skip to content

updates for eslint cleanup #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 26, 2015
Merged

updates for eslint cleanup #618

merged 4 commits into from
Aug 26, 2015

Conversation

mikekidder
Copy link
Contributor

Notes: Minor changes to code in async, real-world examples to clear the eslint errors.

@@ -17,7 +17,7 @@ function verifyStateShape(initialState, currentState) {
var reducerKeys = Object.keys(currentState);

if (reducerKeys.length === 0) {
console.error(
console.error( // eslint-disable-line no-console
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just disable the no-console rule?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could if needed elsewhere. just the three lines needed it in one file. but do agree, this is source.. not examples

@gaearon
Copy link
Contributor

gaearon commented Aug 25, 2015

Is linting no longer running as part of Travis build? Why did we not see these lint errors?

@mikekidder
Copy link
Contributor Author

I looked at history of .travis.yml, don't believe linting was ever part of it?

@gaearon
Copy link
Contributor

gaearon commented Aug 25, 2015

Lol, maybe so. Would you mind adding it?

@hzoo
Copy link

hzoo commented Aug 25, 2015

Might want to update to eslint 1.2.1 and babel-eslint to 4.0.10 as well (although that could be another PR)?

@gaearon
Copy link
Contributor

gaearon commented Aug 25, 2015

@hzoo If you would like to submit a separate PR updating them, please feel free to! I haven't used eslint 1.x yet.

@mikekidder
Copy link
Contributor Author

How about @hzoo adds lint to Travis with that PR. I am getting an error running "npm run lint" under windows, even for the master branch. Throwing an exception in \eslint\lib\config-validator.js, so its going to need to be looked at some more before adding to Travis CI.

@mikekidder
Copy link
Contributor Author

... yeah, its saying this:

Configuration for rule "generator-star-spacing" is invalid:
Value "[object Object]" must be an enum value.

UPDATE: And its not coming from redux's .eslintrc, but a dependency for package "is-nan"
babel-core -> is-nan -> define-properties

n/a to this PR

@mikekidder
Copy link
Contributor Author

Successful linting in Travis CI :)

gaearon added a commit that referenced this pull request Aug 26, 2015
@gaearon gaearon merged commit 5c997b6 into reduxjs:master Aug 26, 2015
@mikekidder
Copy link
Contributor Author

@hzoo I also have changes ready to go with the following npm updates:
babel-eslint 4.1.0, eslint 1.2.1, eslint-plugin-react 3.2.3, eslint-config-airbnb 0.0.8

If you are not working on a PR for it, I will submit. Let me know!

@hzoo
Copy link

hzoo commented Aug 26, 2015

I haven't started it yet so go ahead!

@mikekidder mikekidder deleted the fix.eslint.updates branch August 26, 2015 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants