Skip to content

Invert rows and columns in table of components #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2015

Conversation

pedrottimark
Copy link
Contributor

  1. Easier to read: less wrapping of lines with 2 columns and 4 rows
  2. Easier to read: heading column aligned at the right, component columns aligned at the left
  3. Easier to understand: smart versus dumb components as columns are "dependent variables" in analogy with the x-axis of a graph, or like month columns in a spreadsheet; characteristics as rows are like line items in a spreadsheet.
  4. Easier to modify: you probably won't add another type of component, but you might add another contrasting characteristic (for example, from the bulleted lists in https://medium.com/@dan_abramov/smart-and-dumb-components-7ca2f9a7c7d0). Adding another row to the inverted table would be easy, adding another column to the original table would be harder to do and harder to read.

gaearon added a commit that referenced this pull request Sep 2, 2015
Invert rows and columns in table of components
@gaearon gaearon merged commit 9ef40e9 into reduxjs:master Sep 2, 2015
@gaearon
Copy link
Contributor

gaearon commented Sep 2, 2015

👍

@pedrottimark
Copy link
Contributor Author

Keep up the good work! It is an honor for redux to where I made my first pull request in open source :)

By the way, this change also applies to README.md in react-redux

@pedrottimark pedrottimark deleted the components-table branch September 2, 2015 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants