Adding $(el).timeago('updateFromDOM') function #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you help me understand this a bit more? Do you need this because the underlying |
|
Yup. So the idea is that we have a binding on our abbr element that will update the title attribute if the underlying viewmodel changes. When that happens, we want to be able to force a refresh of the element based on the new title. |
rmm5t
added a commit
that referenced
this pull request
Jun 16, 2013
Adding $(el).timeago('updateFromDOM') function
|
@borski Okay. Merged in. There's now also a 1.3.0 release that incorporates this. Warning: One of these days, I'm going to get around to a v2 rewrite of timeago. I'm not sure this feature will exist in the same form when that time comes. I'm so busy right now though, I have no idea when that will happen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use Knockout.js to automatically update the DOM's values for 'title' or 'datetime' when a date changes, and we needed to be able to refresh the timeago status when the DOM changes.