Skip to content

Correct http header in example #2521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Correct http header in example #2521

merged 1 commit into from
Oct 8, 2019

Conversation

mpoisot
Copy link
Contributor

@mpoisot mpoisot commented Oct 8, 2019

In the last example on this doc page, the http header name used for the token is incorrect.

"Authentication" should be "Authorization"

@daemonsy
Copy link
Contributor

daemonsy commented Oct 8, 2019

Saw the issue you posted, thanks for following up with a PR.

@daemonsy daemonsy merged commit 1050e3a into rmosolgo:master Oct 8, 2019
@rmosolgo
Copy link
Owner

Thanks! I was reading prose, not code samples 🙈

@mpoisot
Copy link
Contributor Author

mpoisot commented Oct 11, 2019

It was good for me to learn how to do the edit via pull request. I didn't realize Github lets you do the entire process on the website now. I thought I was going to have to do 15 minutes of command line pushups for a one line edit.

@rmosolgo
Copy link
Owner

I find myself using it more than I would have guessed, along with the new "suggestion" button 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants