Skip to content

Support repeatable directives #3837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 13, 2022
Merged

Support repeatable directives #3837

merged 2 commits into from
Jan 13, 2022

Conversation

rmosolgo
Copy link
Owner

  • Parse them and print them
  • Allow them to be repeated in queries

Fixes #3571

@rmosolgo rmosolgo added this to the 1.13.5 milestone Jan 13, 2022
@rmosolgo rmosolgo merged commit bb3e055 into master Jan 13, 2022
@rmosolgo rmosolgo deleted the repeatable-directives branch January 13, 2022 15:46
@rmosolgo
Copy link
Owner Author

Oops, I meant to run benchmarks before merging, but I forgot. So I ran them now:

diff --git a/before.txt b/after.txt
index 2d5e40214..c58b71ecf 100644
--- a/before.txt
+++ b/after.txt
@@ -1,16 +1,16 @@
 Warming up --------------------------------------
-scan - introspection   113.000  i/100ms
+scan - introspection   111.000  i/100ms
 parse - introspection
-                        83.000  i/100ms
-    scan - fragments   194.000  i/100ms
-   parse - fragments   142.000  i/100ms
+                        82.000  i/100ms
+    scan - fragments   192.000  i/100ms
+   parse - fragments   140.000  i/100ms
     scan - big query    18.000  i/100ms
    parse - big query    14.000  i/100ms
 Calculating -------------------------------------
-scan - introspection      1.126k (± 1.9%) i/s -      5.650k in   5.018545s
+scan - introspection      1.100k (± 2.2%) i/s -      5.550k in   5.049252s
 parse - introspection
-                        825.404  (± 2.7%) i/s -      4.150k in   5.031397s
-    scan - fragments      1.930k (± 3.1%) i/s -      9.700k in   5.031685s
-   parse - fragments      1.383k (± 2.5%) i/s -      6.958k in   5.033406s
-    scan - big query    193.983  (± 1.5%) i/s -    972.000  in   5.011623s
-   parse - big query    139.962  (± 3.6%) i/s -    700.000  in   5.008677s
+                        821.984  (± 2.8%) i/s -      4.182k in   5.092036s
+    scan - fragments      1.896k (± 2.2%) i/s -      9.600k in   5.066591s
+   parse - fragments      1.369k (± 2.3%) i/s -      6.860k in   5.012959s
+    scan - big query    189.862  (± 2.1%) i/s -    954.000  in   5.027203s
+   parse - big query    139.087  (± 4.3%) i/s -    700.000  in   5.041601s

I wanted to be sure that the new Racc version wasn't any slower, and it looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parse.y union_type_definition or union_type_members seems incompatible with working draft spec and 2018 spec
1 participant