Apply default values that are 'false'

[jamesdphillips]

Unless I'm mistaking the intent it appears I've encountered an issue with false default_values not being applied. I believe this is because the conditional in InputObjectType checks that the coerced value is falsey and not explicitly nil, meaning that false values are being left behind.

See attached patch for (what I suspect) is the correct behaviour. I think my test might be a bit flimsy so I'm open to suggestions. =)

Thanks!

Current Behavior

  IntroduceShipMutation = GraphQL::Relay::Mutation.define do
    name "IntroduceShip"
    description "Add a ship to this faction"

    input_field :isCoolShip, types.Boolean, default_value: false
    return_type types.Boolean

    resolve ->(_, inputs, _) { inputs[:isCoolShip] }
  end

• Considering the above mutation when called with variables { "clientMutationId": "xxx" } the result is nil.
• Considering the above mutation when called with variables { "clientMutationId": "xxx", "isCoolShip": null } the result is nil.
• Considering the above mutation when called with variables { "clientMutationId": "xxx", "isCoolShip": false } the result is false.
• Considering the above mutation when called with variables { "clientMutationId": "xxx", "isCoolShip": true } the result is true.

Anomaly

It's also worth noting that inline variables are unaffected. For instance if I ran the following query the result would be false. Seemingly relevant snippet.

mutation {
  introduceShipMutation(input: { clientMutationId: "xxx" }) # result would be false
}

Expected Behavior

  IntroduceShipMutation = GraphQL::Relay::Mutation.define do
    name "IntroduceShip"
    description "Add a ship to this faction"

    input_field :isCoolShip, types.Boolean, default_value: false
    return_type types.Boolean

    resolve ->(_, inputs, _) { inputs[:isCoolShip] }
  end

• Considering the above mutation when called with variables { "clientMutationId": "xxx" } the result is false.
• Considering the above mutation when called with variables { "clientMutationId": "xxx", "isCoolShip": null } the result is false.
• Considering the above mutation when called with variables { "clientMutationId": "xxx", "isCoolShip": false } the result is false.
• Considering the above mutation when called with variables { "clientMutationId": "xxx", "isCoolShip": true } the result is true.

[rmosolgo]

👍 thanks for hunting this down!

[jamesdphillips]

Thanks! 🎉