Logging in XMPPFramework classes is hard to turn off

[robertjpayne]

If you use CocoaLumberjack elsewhere in your project it is difficult to turn off XMPP logging without currently going through each file and modifying the log level.

XMPPFramework should not use #if DEBUG to determine its logging but rather an internal #DEFINE.

[robbiehanson]

Now you can just do this (in XMPPLogging.h):

#define XMPP_LOGGING_ENABLED 0

[robertjpayne]

May I suggest a small amendment:

#ifndef XMPP_LOGGING_ENABLED
#define XMPP_LOGGING_ENABLED 1
#endif

My goal is to not have to modify XMPP framework at all so I can include the framework and do updates against the main repository without having to "patch" in changes every time.

This change would allow you to define it in a .pch header before XMPP is included and override the default

[robbiehanson]

Great idea!

[chen182459312]

Hi, Robbie Hanson, I used the TurnSocket to transmit file, my server is ejabberd. I test the iChat and Adium can be transmit file. but when I used the iPhone simulator, the "- (void)turnSocketDidFail:(TURNSocket *)sender" was called every times. first, I must set the proxy server array? second, i must use the full JID to receiver name?
there is my code:
NSArray * array = [NSArray arrayWithObjects:@"conference.mini.local",@"pubsub.mini.local", @"vjud.mini.local", nil]; //
[TURNSocket setProxyCandidates: array];
XMPPJID *jid = [XMPPJID jidWithString : @"[email protected]/mini" ];
_objTURNSocket = [[TURNSocket alloc] initWithStream:_xmppStream toJID: jid ];
[_objTURNSocket startWithDelegate:self delegateQueue:dispatch_get_main_queue() ];
the proxy servers is when I was send this:
-(BOOL)getProxyServers
{

NSError *error = nil;
NSString *strXML = @"<iq type='get'\
from='[email protected]'\
to='mini.local'\
id='server_items'>\
<query xmlns='http://jabber.org/protocol/disco#items'/>\
</iq>" ;
NSXMLElement *qust = [[NSXMLElement alloc] initWithXMLString: strXML error: &error ];
NSLog(@"err :%@", error);
[_xmppStream sendElement:qust];

} and the, I receive the items: @"conference.mini.local",@"pubsub.mini.local", @"vjud.mini.local"