Fall back to 'Fit (grey edges) in' when 'Fit (reflect edges) in' / 'Fit within' / 'Fill (with center crop) in' is passed as resize method #1584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it within' / 'Fill (with center crop) in' is passed as resize method
grzegorz-roboflow
requested review from
PawelPeczek-Roboflow,
hansent,
probicheaux and
yeldarby
as code owners
hansent
reviewed
Sep 24, 2025
| "Unsupported resize method '%s', defaulting to 'Fit (grey edges) in' - this may result in degraded model performance.", | ||
| self.resize_method, | ||
| ) | ||
| self.resize_method = "Fit (grey edges) in" |
Collaborator
There was a problem hiding this comment.
is this actually correct or do we implement the correct resize methods?
Collaborator
There was a problem hiding this comment.
These are options we give in the UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following resize methods were defaulting to 'Stretch to':
This change is logging error when this happens, and is defaulting these methods to 'Fit (grey edges) in'
Type of change
How has this change been tested, please provide a testcase or example of how you tested the change?
CI passing
Tested manually
Any specific deployment considerations
N/A
Docs
N/A