Skip to content

feat: 📝 static type improvement color constants and PolygonZone #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

onuralpszr
Copy link
Collaborator

@onuralpszr onuralpszr commented Mar 17, 2024


Python 3.10.13 (main, Aug 24 2023, 12:59:26) [Clang 15.0.0 (clang-1500.1.0.2.5)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import supervision as sv

>>>
>>> type(sv.Color.WHITE)
<class 'supervision.draw.color.Color'>

Fix: #1010

@onuralpszr onuralpszr added the bug Something isn't working label Mar 17, 2024
@onuralpszr onuralpszr requested a review from SkalskiP March 17, 2024 11:42
@onuralpszr onuralpszr self-assigned this Mar 17, 2024
@onuralpszr onuralpszr force-pushed the feat/type-check-improvement branch from 98be1fc to e8810fe Compare March 17, 2024 11:43
@onuralpszr
Copy link
Collaborator Author

@SkalskiP color types are fixed.

@onuralpszr onuralpszr force-pushed the feat/type-check-improvement branch from a0c60fc to 63b3387 Compare March 17, 2024 15:17
@onuralpszr onuralpszr changed the title fix: 🐞 static type fix for color constants to sv.Color fix: 🐞 static type fix for color constants to sv.Color and PolygonZone Mar 17, 2024
@onuralpszr onuralpszr changed the title fix: 🐞 static type fix for color constants to sv.Color and PolygonZone feat: 📝 static type improvement color constants and PolygonZone Mar 17, 2024
@onuralpszr
Copy link
Collaborator Author

@SkalskiP I also changed my title and added extra improvement for polygonZone as well, tests are passed. Please check when you had time as well :)

@SkalskiP SkalskiP merged commit 77908fe into develop Mar 18, 2024
@onuralpszr onuralpszr deleted the feat/type-check-improvement branch September 23, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Color] - constants like WHITE, BLACK, RED, and so on have the wrong type.
2 participants