testscript: explore addition of io/fs.FS to Params #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myitcv
force-pushed
the
testscript_io_fs_FS
branch
from
4a83ff8 to
5d7ff47
Compare
|
The build failures are as a result of golang/go#40067 (comment). So whilst not directly caused by this change, this change does exacerbate the situation. |
myitcv
force-pushed
the
testscript_io_fs_FS
branch
from
5d7ff47 to
589c05e
Compare
|
Per a quick chat with @mvdan, perhaps a better approach here is to walk the entire |
DO NOT SUBMIT
myitcv
force-pushed
the
testscript_io_fs_FS
branch
from
589c05e to
79f8251
Compare
|
This has been sitting around long enough that I think it can be closed. It's not clear exactly what need is being addressed here. Feel free to reopen if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT SUBMIT