add rosgraph_msgs package with Clock message #50
Merged
+62
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosgraph_msgs/msg/Clock.msg
Outdated
| @@ -0,0 +1,4 @@ | |||
| # roslib/Clock is used for publishing simulated time in ROS. | |||
Member
Author
There was a problem hiding this comment.
Yes, copied 1-to-1 from ROS 1.
Member
There was a problem hiding this comment.
Please update the comment as there is no such thing as roslib/Clock in ROS 2. And this doesn't exist in ROS1 since C-Turtle either from what I can tell
mikaelarguedas
approved these changes
Mar 26, 2018
Member
mikaelarguedas
left a comment
mikaelarguedas
left a comment
There was a problem hiding this comment.
lgtm (didn't test bridging it though).
Should this be blacklisted on CI like the other messages unused by our current test suite ?
Member
Author
I would rather not blacklist it since it is only a single message. |
Member
Fine by me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ros2/ros1_bridge#104. Connect to ros2/ros1_bridge#104.
This adds the
Clockmessage from the rosgraph_msgs package.The other two messages fro ROS 1 seem to not have a 1-to-1 equivalent in ROS 2 therefore I didn't add them at this point.