Skip to content

rename RosTimer -> ROSTimer and PushRosNamepsace -> PushROSNamespace #3038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 28, 2022
Merged

rename RosTimer -> ROSTimer and PushRosNamepsace -> PushROSNamespace #3038

merged 3 commits into from
Sep 28, 2022

Conversation

@wjwwood
Copy link
Member

@wjwwood wjwwood commented Sep 24, 2022

@wjwwood
Copy link
Member Author

wjwwood commented Sep 24, 2022

This should probably be noted in the Iron release notes, is there not a page for that yet?

@wjwwood wjwwood self-assigned this Sep 24, 2022
@wjwwood wjwwood mentioned this pull request Sep 24, 2022
Merged
@clalancette
Copy link
Contributor

clalancette commented Sep 24, 2022

This should probably be noted in the Iron release notes, is there not a page for that yet?

There is a page: https://github.com/ros2/ros2_documentation/blob/rolling/source/Releases/Release-Iron-Irwini.rst

fujitatomoya
fujitatomoya approved these changes Sep 24, 2022
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wjwwood
not about changed class names
3fa4a29 
Signed-off-by: William Woodall <[email protected]>
@wjwwood
Copy link
Member Author

wjwwood commented Sep 27, 2022

I don't know how I missed it the first time, thanks @clalancette. I added a note there about the change.

@wjwwood
reword
eb49efd 
Signed-off-by: William Woodall <[email protected]>
@wjwwood wjwwood merged commit 9db3fda into rolling Sep 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the rename_Ros_to_ROS branch September 28, 2022 18:38
@mergify mergify bot mentioned this pull request Sep 28, 2022
Merged
mergify bot pushed a commit that referenced this pull request Sep 28, 2022
@wjwwood @mergify
rename RosTimer -> ROSTimer and PushRosNamepsace -> PushROSNamespace (#…
7a9e7d0 
…3038)

* rename RosTimer -> ROSTimer and PushRosNamepsace -> PushROSNamespace

Signed-off-by: William Woodall <[email protected]>

* not about changed class names

Signed-off-by: William Woodall <[email protected]>

* reword

Signed-off-by: William Woodall <[email protected]>

Signed-off-by: William Woodall <[email protected]>
(cherry picked from commit 9db3fda)
mergify bot pushed a commit that referenced this pull request Sep 28, 2022
@wjwwood @mergify
rename RosTimer -> ROSTimer and PushRosNamepsace -> PushROSNamespace (#…
e7e4cfa 
…3038)

* rename RosTimer -> ROSTimer and PushRosNamepsace -> PushROSNamespace

Signed-off-by: William Woodall <[email protected]>

* not about changed class names

Signed-off-by: William Woodall <[email protected]>

* reword

Signed-off-by: William Woodall <[email protected]>

Signed-off-by: William Woodall <[email protected]>
(cherry picked from commit 9db3fda)

# Conflicts:
#	source/How-To-Guides/Launch-file-different-formats.rst
This was referenced Sep 28, 2022
Merged
Merged
mergify bot pushed a commit that referenced this pull request Sep 28, 2022
@wjwwood @mergify
rename RosTimer -> ROSTimer and PushRosNamepsace -> PushROSNamespace (#…
46cbfaa 
…3038)

* rename RosTimer -> ROSTimer and PushRosNamepsace -> PushROSNamespace

Signed-off-by: William Woodall <[email protected]>

* not about changed class names

Signed-off-by: William Woodall <[email protected]>

* reword

Signed-off-by: William Woodall <[email protected]>

Signed-off-by: William Woodall <[email protected]>
(cherry picked from commit 9db3fda)

# Conflicts:
#	source/How-To-Guides/Launch-file-different-formats.rst
clalancette pushed a commit that referenced this pull request Sep 28, 2022
@wjwwood @clalancette
rename RosTimer -> ROSTimer and PushRosNamepsace -> PushROSNamespace (#…
87c4b44 
…3038)

Signed-off-by: William Woodall <[email protected]>

Signed-off-by: William Woodall <[email protected]>
(cherry picked from commit 9db3fda)
clalancette pushed a commit that referenced this pull request Sep 28, 2022
@wjwwood @clalancette
rename RosTimer -> ROSTimer and PushRosNamepsace -> PushROSNamespace (#…
9ea4907 
…3038)

Signed-off-by: William Woodall <[email protected]>

Signed-off-by: William Woodall <[email protected]>
(cherry picked from commit 9db3fda)
clalancette pushed a commit that referenced this pull request Sep 28, 2022
@wjwwood @clalancette
rename RosTimer -> ROSTimer and PushRosNamepsace -> PushROSNamespace (#…
a0e2d66 
…3038)

Signed-off-by: William Woodall <[email protected]>

Signed-off-by: William Woodall <[email protected]>
(cherry picked from commit 9db3fda)
clalancette pushed a commit that referenced this pull request Sep 28, 2022
@mergify @wjwwood
rename RosTimer -> ROSTimer and PushRosNamepsace -> PushROSNamespace (#…
40dca08 
…3038) (#3053)

Signed-off-by: William Woodall <[email protected]>

Signed-off-by: William Woodall <[email protected]>
(cherry picked from commit 9db3fda)

Co-authored-by: William Woodall <[email protected]>
clalancette pushed a commit that referenced this pull request Sep 28, 2022
@mergify @wjwwood
rename RosTimer -> ROSTimer and PushRosNamepsace -> PushROSNamespace (#…
0d50550 
…3038) (#3054)

Signed-off-by: William Woodall <[email protected]>

Signed-off-by: William Woodall <[email protected]>
(cherry picked from commit 9db3fda)

Co-authored-by: William Woodall <[email protected]>
clalancette pushed a commit that referenced this pull request Sep 28, 2022
@mergify @wjwwood
rename RosTimer -> ROSTimer and PushRosNamepsace -> PushROSNamespace (#…
ed17fc6 
…3038) (#3055)

Signed-off-by: William Woodall <[email protected]>

Signed-off-by: William Woodall <[email protected]>
(cherry picked from commit 9db3fda)

Co-authored-by: William Woodall <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@clalancette clalancette Awaiting requested review from clalancette

@ivanpauno ivanpauno Awaiting requested review from ivanpauno

@jacobperron jacobperron Awaiting requested review from jacobperron

Assignees

@wjwwood wjwwood

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wjwwood @clalancette @fujitatomoya