Add jsonschema to windows install requirements #3356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emerson Knapp <[email protected]>
This was referenced Mar 2, 2023
nuclearsandwich
approved these changes
Mar 3, 2023
Member
nuclearsandwich
left a comment
nuclearsandwich
left a comment
There was a problem hiding this comment.
The features requiring this dependency won't be backported to Humble correct?
Contributor
Author
|
Correct, it's new rosidl code generator behavior for Iron+, I don't see a way it would be backportable |
clalancette
approved these changes
Mar 6, 2023
Contributor
|
I'm just going to go ahead and merge this one; as a documentation change and the addition of a new dependency, worst case is that someone installs a dependency that we aren't quite using yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ros2/ci#695
Related to ros-infrastructure/ros2-cookbooks#52
Requirement for ros2/rosidl#722
See ros2/rosidl#722 (comment)