Update Code-Style-Language-Versions.rst #4925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compatibility with versions of CMake older than 3.10 is now deprecated and will be removed from a future version. Oldest supported Ubuntu 20.04 use cmake 3.15 https://cmake.org/cmake/help/v3.31/release/3.31.html Signed-off-by: mosfet80 <[email protected]>
fujitatomoya
reviewed
Jan 7, 2025
Collaborator
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
CMake versions are different for each platform, we would want to remove the version here and link https://www.ros.org/reps/rep-2000.html#jazzy-jalisco-may-2024-may-2029 instead?
Contributor
Author
looking at the tables in the link, the oldest cmake version used among the supported ros versions is 3.16.5. this corresponds to the use of ros humble on openembedded |
Signed-off-by: mosfet80 <[email protected]>
sloretz
requested changes
Jan 16, 2025
Contributor
sloretz
left a comment
sloretz
left a comment
There was a problem hiding this comment.
+1 to including a link to REP 2000, and also +1 to including the minimum version of any supported ROS distro so the reader doesn't have to look through it.
source/The-ROS2-Project/Contributing/Code-Style-Language-Versions.rst
Outdated
Show resolved
Hide resolved
…ons.rst Co-authored-by: Shane Loretz <[email protected]> Signed-off-by: mosfet80 <[email protected]>
sloretz
reviewed
Jul 17, 2025
source/The-ROS2-Project/Contributing/Code-Style-Language-Versions.rst
Outdated
Show resolved
Hide resolved
Signed-off-by: Shane Loretz <[email protected]>
sloretz
reviewed
Jul 17, 2025
source/The-ROS2-Project/Contributing/Code-Style-Language-Versions.rst
Outdated
Show resolved
Hide resolved
Signed-off-by: Shane Loretz <[email protected]>
fujitatomoya
approved these changes
Jul 18, 2025
fujitatomoya
added
the
backport-all
mergify bot
pushed a commit
that referenced
this pull request
Jul 18, 2025
* Update Code-Style-Language-Versions.rst Compatibility with versions of CMake older than 3.10 is now deprecated and will be removed from a future version. Oldest supported Ubuntu 20.04 use cmake 3.15 https://cmake.org/cmake/help/v3.31/release/3.31.html Signed-off-by: mosfet80 <[email protected]> * Update Code-Style-Language-Versions.rst Signed-off-by: mosfet80 <[email protected]> * Update source/The-ROS2-Project/Contributing/Code-Style-Language-Versions.rst Co-authored-by: Shane Loretz <[email protected]> Signed-off-by: mosfet80 <[email protected]> * Use RST link syntax Signed-off-by: Shane Loretz <[email protected]> * Fix RST link syntax Signed-off-by: Shane Loretz <[email protected]> --------- Signed-off-by: mosfet80 <[email protected]> Signed-off-by: mosfet80 <[email protected]> Signed-off-by: Shane Loretz <[email protected]> Co-authored-by: Shane Loretz <[email protected]> (cherry picked from commit 709e210)
mergify bot
pushed a commit
that referenced
this pull request
Jul 18, 2025
* Update Code-Style-Language-Versions.rst Compatibility with versions of CMake older than 3.10 is now deprecated and will be removed from a future version. Oldest supported Ubuntu 20.04 use cmake 3.15 https://cmake.org/cmake/help/v3.31/release/3.31.html Signed-off-by: mosfet80 <[email protected]> * Update Code-Style-Language-Versions.rst Signed-off-by: mosfet80 <[email protected]> * Update source/The-ROS2-Project/Contributing/Code-Style-Language-Versions.rst Co-authored-by: Shane Loretz <[email protected]> Signed-off-by: mosfet80 <[email protected]> * Use RST link syntax Signed-off-by: Shane Loretz <[email protected]> * Fix RST link syntax Signed-off-by: Shane Loretz <[email protected]> --------- Signed-off-by: mosfet80 <[email protected]> Signed-off-by: mosfet80 <[email protected]> Signed-off-by: Shane Loretz <[email protected]> Co-authored-by: Shane Loretz <[email protected]> (cherry picked from commit 709e210)
mergify bot
pushed a commit
that referenced
this pull request
Jul 18, 2025
* Update Code-Style-Language-Versions.rst Compatibility with versions of CMake older than 3.10 is now deprecated and will be removed from a future version. Oldest supported Ubuntu 20.04 use cmake 3.15 https://cmake.org/cmake/help/v3.31/release/3.31.html Signed-off-by: mosfet80 <[email protected]> * Update Code-Style-Language-Versions.rst Signed-off-by: mosfet80 <[email protected]> * Update source/The-ROS2-Project/Contributing/Code-Style-Language-Versions.rst Co-authored-by: Shane Loretz <[email protected]> Signed-off-by: mosfet80 <[email protected]> * Use RST link syntax Signed-off-by: Shane Loretz <[email protected]> * Fix RST link syntax Signed-off-by: Shane Loretz <[email protected]> --------- Signed-off-by: mosfet80 <[email protected]> Signed-off-by: mosfet80 <[email protected]> Signed-off-by: Shane Loretz <[email protected]> Co-authored-by: Shane Loretz <[email protected]> (cherry picked from commit 709e210)
fujitatomoya
pushed a commit
that referenced
this pull request
Jul 18, 2025
* Update Code-Style-Language-Versions.rst Compatibility with versions of CMake older than 3.10 is now deprecated and will be removed from a future version. Oldest supported Ubuntu 20.04 use cmake 3.15 https://cmake.org/cmake/help/v3.31/release/3.31.html * Update Code-Style-Language-Versions.rst * Update source/The-ROS2-Project/Contributing/Code-Style-Language-Versions.rst * Use RST link syntax * Fix RST link syntax --------- (cherry picked from commit 709e210) Signed-off-by: mosfet80 <[email protected]> Signed-off-by: mosfet80 <[email protected]> Signed-off-by: Shane Loretz <[email protected]> Co-authored-by: mosfet80 <[email protected]> Co-authored-by: Shane Loretz <[email protected]>
fujitatomoya
pushed a commit
that referenced
this pull request
Jul 18, 2025
* Update Code-Style-Language-Versions.rst Compatibility with versions of CMake older than 3.10 is now deprecated and will be removed from a future version. Oldest supported Ubuntu 20.04 use cmake 3.15 https://cmake.org/cmake/help/v3.31/release/3.31.html * Update Code-Style-Language-Versions.rst * Update source/The-ROS2-Project/Contributing/Code-Style-Language-Versions.rst * Use RST link syntax * Fix RST link syntax --------- (cherry picked from commit 709e210) Signed-off-by: mosfet80 <[email protected]> Signed-off-by: mosfet80 <[email protected]> Signed-off-by: Shane Loretz <[email protected]> Co-authored-by: mosfet80 <[email protected]> Co-authored-by: Shane Loretz <[email protected]>
fujitatomoya
pushed a commit
that referenced
this pull request
Jul 18, 2025
* Update Code-Style-Language-Versions.rst Compatibility with versions of CMake older than 3.10 is now deprecated and will be removed from a future version. Oldest supported Ubuntu 20.04 use cmake 3.15 https://cmake.org/cmake/help/v3.31/release/3.31.html * Update Code-Style-Language-Versions.rst * Update source/The-ROS2-Project/Contributing/Code-Style-Language-Versions.rst * Use RST link syntax * Fix RST link syntax --------- (cherry picked from commit 709e210) Signed-off-by: mosfet80 <[email protected]> Signed-off-by: mosfet80 <[email protected]> Signed-off-by: Shane Loretz <[email protected]> Co-authored-by: mosfet80 <[email protected]> Co-authored-by: Shane Loretz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compatibility with versions of CMake older than 3.10 is now deprecated and will be removed from a future version. Oldest supported Ubuntu 20.04 use cmake 3.15
https://cmake.org/cmake/help/v3.31/release/3.31.html