Skip to content

Conversation

@fujitatomoya
Copy link
Collaborator

Signed-off-by: Tomoya Fujita <[email protected]>
@fujitatomoya fujitatomoya self-assigned this Mar 13, 2025
@fujitatomoya fujitatomoya requested a review from ahcorde March 13, 2025 18:19
Copy link
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding the same notice that says this is what you can see on your subscription, not publisher statistics

@fujitatomoya
Copy link
Collaborator Author

@ahcorde can you review this?

@github-actions
Copy link

github-actions bot commented Mar 13, 2025

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/13845274942/artifacts/2749105230.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-5087/index.html in your favorite browser

Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the notes explicitly also say that the rate/bandwidth reported by the tools can therefore be misleading?

Example:

... and may not exactly match the publisher's rate/bandwidth. Therefore, the reported value may be misleading.

Signed-off-by: Tomoya Fujita <[email protected]>
@fujitatomoya
Copy link
Collaborator Author

Should the notes explicitly also say that the rate/bandwidth reported by the tools can therefore be misleading?

i am not sure about this. on the subscription statistics with platform, network constraints and QoS configuration, this is what they can get. that actually sounds true for me, so maybe not misleading??? 🤔🤔🤔

@christophebedard
Copy link
Member

christophebedard commented Mar 13, 2025

It's true, but it's misleading if they think it represents the publisher rate/bandwidth. I was wondering if it would be worth it to explicitly mention that this is not the publisher rate, on top of saying that this actually represents the subscription's reception rate. This way, it's more explicit and hopefully clearer, especially since the ros2 topic hz section still says:

You can also view the rate at which data is published using:

It's kind of the difference between saying "this does X" and saying "this does X and not Y," if that makes sense.

@christophebedard
Copy link
Member

Oh, I kind of missed the last part of the note

and may not exactly match the publisher rate.

Nevermind then, this is good 😅

@christophebedard christophebedard added the backport-all backport at reviewers discretion; from rolling to all versions label Mar 13, 2025
@fujitatomoya fujitatomoya merged commit 45b1e8a into rolling Mar 13, 2025
5 checks passed
@fujitatomoya fujitatomoya deleted the fujitatomoya/adjust-topic-hz-bw-note branch March 13, 2025 23:33
mergify bot pushed a commit that referenced this pull request Mar 13, 2025
* add note for ros2 topic hz/bw.

Signed-off-by: Tomoya Fujita <[email protected]>

* address review comments.

Signed-off-by: Tomoya Fujita <[email protected]>

---------

Signed-off-by: Tomoya Fujita <[email protected]>
(cherry picked from commit 45b1e8a)
mergify bot pushed a commit that referenced this pull request Mar 13, 2025
* add note for ros2 topic hz/bw.

Signed-off-by: Tomoya Fujita <[email protected]>

* address review comments.

Signed-off-by: Tomoya Fujita <[email protected]>

---------

Signed-off-by: Tomoya Fujita <[email protected]>
(cherry picked from commit 45b1e8a)
fujitatomoya added a commit that referenced this pull request Mar 13, 2025
* add note for ros2 topic hz/bw.

Signed-off-by: Tomoya Fujita <[email protected]>

* address review comments.

Signed-off-by: Tomoya Fujita <[email protected]>

---------

Signed-off-by: Tomoya Fujita <[email protected]>
(cherry picked from commit 45b1e8a)

Co-authored-by: Tomoya Fujita <[email protected]>
fujitatomoya added a commit that referenced this pull request Mar 13, 2025
* add note for ros2 topic hz/bw.

Signed-off-by: Tomoya Fujita <[email protected]>

* address review comments.

Signed-off-by: Tomoya Fujita <[email protected]>

---------

Signed-off-by: Tomoya Fujita <[email protected]>
(cherry picked from commit 45b1e8a)

Co-authored-by: Tomoya Fujita <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-all backport at reviewers discretion; from rolling to all versions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants