-
Notifications
You must be signed in to change notification settings - Fork 1.2k
add note for ros2 topic hz/bw. #5087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Tomoya Fujita <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding the same notice that says this is what you can see on your subscription, not publisher statistics
|
@ahcorde can you review this? |
|
HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/13845274942/artifacts/2749105230. To view the resulting site:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the notes explicitly also say that the rate/bandwidth reported by the tools can therefore be misleading?
Example:
... and may not exactly match the publisher's rate/bandwidth. Therefore, the reported value may be misleading.
source/Tutorials/Beginner-CLI-Tools/Understanding-ROS2-Topics/Understanding-ROS2-Topics.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Beginner-CLI-Tools/Understanding-ROS2-Topics/Understanding-ROS2-Topics.rst
Outdated
Show resolved
Hide resolved
Signed-off-by: Tomoya Fujita <[email protected]>
i am not sure about this. on the subscription statistics with platform, network constraints and QoS configuration, this is |
|
It's true, but it's misleading if they think it represents the publisher rate/bandwidth. I was wondering if it would be worth it to explicitly mention that this is not the publisher rate, on top of saying that this actually represents the subscription's reception rate. This way, it's more explicit and hopefully clearer, especially since the
It's kind of the difference between saying "this does X" and saying "this does X and not Y," if that makes sense. |
|
Oh, I kind of missed the last part of the note
Nevermind then, this is good 😅 |
* add note for ros2 topic hz/bw. Signed-off-by: Tomoya Fujita <[email protected]> * address review comments. Signed-off-by: Tomoya Fujita <[email protected]> --------- Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 45b1e8a)
* add note for ros2 topic hz/bw. Signed-off-by: Tomoya Fujita <[email protected]> * address review comments. Signed-off-by: Tomoya Fujita <[email protected]> --------- Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 45b1e8a)
* add note for ros2 topic hz/bw. Signed-off-by: Tomoya Fujita <[email protected]> * address review comments. Signed-off-by: Tomoya Fujita <[email protected]> --------- Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 45b1e8a) Co-authored-by: Tomoya Fujita <[email protected]>
* add note for ros2 topic hz/bw. Signed-off-by: Tomoya Fujita <[email protected]> * address review comments. Signed-off-by: Tomoya Fujita <[email protected]> --------- Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 45b1e8a) Co-authored-by: Tomoya Fujita <[email protected]>
part of ros2/ros2cli#843 (comment)
aligns with ros2/ros2cli#987