Update documentation for automatic spellcheck #5105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b.com/SuperGops7/ros2_documentation into docs-update-automatic-code-spellcheck
fujitatomoya
requested changes
Mar 16, 2025
Collaborator
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
@SuperGops7 thanks for the PR, i have several comments.
source/The-ROS2-Project/Contributing/Contributing-To-ROS-2-Documentation.rst
Show resolved
Hide resolved
source/The-ROS2-Project/Contributing/Contributing-To-ROS-2-Documentation.rst
Outdated
Show resolved
Hide resolved
source/The-ROS2-Project/Contributing/Contributing-To-ROS-2-Documentation.rst
Outdated
Show resolved
Hide resolved
source/The-ROS2-Project/Contributing/Contributing-To-ROS-2-Documentation.rst
Outdated
Show resolved
Hide resolved
kscottz
approved these changes
Mar 17, 2025
Collaborator
kscottz
left a comment
kscottz
left a comment
There was a problem hiding this comment.
LGTM once you address @fujitatomoya's concerns. 👍🏻
Collaborator
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
@SuperGops7 almost lgtm, can you address one last comment?
fujitatomoya
approved these changes
Mar 18, 2025
Collaborator
|
@SuperGops7 really appreciate your effort! thank you! merging 🚀🚀🚀 |
fujitatomoya
added
the
backport-all
mergify bot
pushed a commit
that referenced
this pull request
Mar 18, 2025
* docs: initial update * docs: update-environment-hooks * chore: lint fixes * chore: update doc as per PR comments * chore: update PR review comments * chore: update gitignore * docs: update docs for automatic spellcheck * chore: update as per PR comments * chore: update as per PR comments --------- Co-authored-by: SuperGops7 <[email protected]> (cherry picked from commit 5d72271)
mergify bot
pushed a commit
that referenced
this pull request
Mar 18, 2025
* docs: initial update * docs: update-environment-hooks * chore: lint fixes * chore: update doc as per PR comments * chore: update PR review comments * chore: update gitignore * docs: update docs for automatic spellcheck * chore: update as per PR comments * chore: update as per PR comments --------- Co-authored-by: SuperGops7 <[email protected]> (cherry picked from commit 5d72271)
fujitatomoya
pushed a commit
that referenced
this pull request
Mar 18, 2025
* docs: initial update * docs: update-environment-hooks * chore: lint fixes * chore: update doc as per PR comments * chore: update PR review comments * chore: update gitignore * docs: update docs for automatic spellcheck * chore: update as per PR comments * chore: update as per PR comments --------- Co-authored-by: SuperGops7 <[email protected]> (cherry picked from commit 5d72271) Co-authored-by: Gopikrishnan K <[email protected]>
fujitatomoya
pushed a commit
that referenced
this pull request
Mar 18, 2025
* docs: initial update * docs: update-environment-hooks * chore: lint fixes * chore: update doc as per PR comments * chore: update PR review comments * chore: update gitignore * docs: update docs for automatic spellcheck * chore: update as per PR comments * chore: update as per PR comments --------- Co-authored-by: SuperGops7 <[email protected]> (cherry picked from commit 5d72271) Co-authored-by: Gopikrishnan K <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the docs for automatic spellcheck.
Fixes #5075