RQt install by source for Windows and Mac #56
Conversation
|
This is a pointless comment, but the short hash of 5600065 is a palindrome. |
brawner
force-pushed
the
rqt2_windows
branch
from
5600065 to
7304a8c
Compare
|
Rebased to master after #28 merged, but I need to resolve RQt-Source-Install.rst |
brawner
force-pushed
the
rqt2_windows
branch
from
7304a8c to
a06f046
Compare
|
Successfully rebased this time. New commit short hash is sadly not a palindrome |
dirk-thomas
left a comment
dirk-thomas
left a comment
There was a problem hiding this comment.
Please start each sentence on a new line as described in the developer guide.
RQt-Port-Plugin-Windows.rst
Outdated
|
|
||
| RQt Porting examples | ||
| ------------------------- | ||
| Microsoft pushed an effort to port much of ROS to Windows, their repos are a good resource for necessary changes. They live at the ms-iot organization with branches called init-windows. For example: https://github.com/ms-iot/qt_gui_core/tree/init_windows |
There was a problem hiding this comment.
How is this relevant for a developer porting their plugin?
There was a problem hiding this comment.
It gives more examples of porting ROS1 rqt plugins to Windows. It was helpful to me
|
|
||
| Checkout `this PR <https://github.com/ros-visualization/qt_gui_core/pull/147>`_ for an example of porting to TinyXML2. | ||
|
|
||
| Code that uses ``__cplusplus`` and code that requires pluginlib |
There was a problem hiding this comment.
Again, how is this relevant for a developer porting their plugin?
Same for the majority following below.
There was a problem hiding this comment.
Because it's an idiosyncrasy of compiling c++ code on Windows. And as most ROS2 developers aren't aware of this issue, that flag might be used elsewhere and lead to unintended effects on Windows. At least it's captured here
| .. code-block:: bash | ||
|
|
||
| $ export PATH="$(brew --prefix qt)/bin:$PATH" | ||
| $ export CMAKE_PREFIX_PATH="$(brew --prefix qt):$CMAKE_PREFIX_PATH" |
There was a problem hiding this comment.
How are these instructions different from the existing generic instructions in this repo?
There was a problem hiding this comment.
The instructions in OSX-Development-Setup.rst are insufficient. I pulled that block from your contribution to Set-up-a-new-macOS-CI-node.rst, which I don't think many rqt developers will look at.
There was a problem hiding this comment.
I would suggest to reference existing instructions wherever possible instead of copy-n-pasting.
There was a problem hiding this comment.
While that sounds reasonable, I don't think this would be a good case for it unless this information is to get added to OSX-Development-Setup.rst. The page about building a CI node is unrelated to this documentation.
brawner
force-pushed
the
rqt2_windows
branch
from
a06f046 to
8b6632a
Compare
#5916) * Revert "Revert "Minor RTI Connext DDS documentation improvements (#5606)" (#5915)" This reverts commit 8f7d0c4. Signed-off-by: Tomoya.Fujita <[email protected]> * fix lint error, one sentence per line. Signed-off-by: Tomoya.Fujita <[email protected]> --------- Signed-off-by: Tomoya.Fujita <[email protected]>
#5916) * Revert "Revert "Minor RTI Connext DDS documentation improvements (#5606)" (#5915)" This reverts commit 8f7d0c4. Signed-off-by: Tomoya.Fujita <[email protected]> * fix lint error, one sentence per line. Signed-off-by: Tomoya.Fujita <[email protected]> --------- Signed-off-by: Tomoya.Fujita <[email protected]> (cherry picked from commit f85df74)
#5916) (#5917) * Revert "Revert "Minor RTI Connext DDS documentation improvements (#5606)" (#5915)" This reverts commit 8f7d0c4. * fix lint error, one sentence per line. --------- (cherry picked from commit f85df74) Signed-off-by: Tomoya.Fujita <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]>
3 participants
This adds more information to the RQt wiki pages that is mostly specific to building and using on Mac and Windows.
Depends on #28
New commit: a06f046