Skip to content

Conversation

@christophfroehlich
Copy link
Contributor

The pluginlib page has some issues.

First, I don't think that the area_node should be part of the library: add_library(${PROJECT_NAME} SHARED src/area_node.cpp)
As proposed here I changed it to be an INTERFACE library.

As a consequence,

ament_export_libraries(
      ${PROJECT_NAME}
    )

does not work any more.

Additionally,

    install(
      DIRECTORY include/
      DESTINATION include
    )

was a duplicate with different destination.

Signed-off-by: Christoph Fröhlich <[email protected]>
Signed-off-by: Christoph Fröhlich <[email protected]>
Signed-off-by: Christoph Fröhlich <[email protected]>
Signed-off-by: Christoph Fröhlich <[email protected]>
@ahcorde ahcorde added the backport-all backport at reviewers discretion; from rolling to all versions label Sep 29, 2025
@ahcorde ahcorde merged commit c87aa57 into ros2:rolling Sep 29, 2025
5 checks passed
mergify bot pushed a commit that referenced this pull request Sep 29, 2025
Signed-off-by: Christoph Fröhlich <[email protected]>
(cherry picked from commit c87aa57)
mergify bot pushed a commit that referenced this pull request Sep 29, 2025
Signed-off-by: Christoph Fröhlich <[email protected]>
(cherry picked from commit c87aa57)

# Conflicts:
#	source/Tutorials/Beginner-Client-Libraries/Pluginlib.rst
mergify bot pushed a commit that referenced this pull request Sep 29, 2025
Signed-off-by: Christoph Fröhlich <[email protected]>
(cherry picked from commit c87aa57)

# Conflicts:
#	source/Tutorials/Beginner-Client-Libraries/Pluginlib.rst
ahcorde pushed a commit that referenced this pull request Sep 29, 2025
(cherry picked from commit c87aa57)

Signed-off-by: Christoph Fröhlich <[email protected]>
Co-authored-by: Christoph Fröhlich <[email protected]>
ahcorde added a commit that referenced this pull request Sep 29, 2025
* Update Pluginlib.rst (#5894)

Signed-off-by: Christoph Fröhlich <[email protected]>
(cherry picked from commit c87aa57)

Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Co-authored-by: Christoph Fröhlich <[email protected]>
Co-authored-by: Alejandro Hernandez Cordero <[email protected]>
ahcorde added a commit that referenced this pull request Sep 29, 2025
* Update Pluginlib.rst (#5894)

Signed-off-by: Christoph Fröhlich <[email protected]>
(cherry picked from commit c87aa57)

Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Co-authored-by: Christoph Fröhlich <[email protected]>
Co-authored-by: Alejandro Hernandez Cordero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-all backport at reviewers discretion; from rolling to all versions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants