-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update Pluginlib.rst #5894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update Pluginlib.rst #5894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Fröhlich <[email protected]>
Signed-off-by: Christoph Fröhlich <[email protected]>
Signed-off-by: Christoph Fröhlich <[email protected]>
Signed-off-by: Christoph Fröhlich <[email protected]>
This was referenced Sep 29, 2025
ahcorde
approved these changes
Sep 29, 2025
mergify bot
pushed a commit
that referenced
this pull request
Sep 29, 2025
Signed-off-by: Christoph Fröhlich <[email protected]> (cherry picked from commit c87aa57)
mergify bot
pushed a commit
that referenced
this pull request
Sep 29, 2025
Signed-off-by: Christoph Fröhlich <[email protected]> (cherry picked from commit c87aa57) # Conflicts: # source/Tutorials/Beginner-Client-Libraries/Pluginlib.rst
mergify bot
pushed a commit
that referenced
this pull request
Sep 29, 2025
Signed-off-by: Christoph Fröhlich <[email protected]> (cherry picked from commit c87aa57) # Conflicts: # source/Tutorials/Beginner-Client-Libraries/Pluginlib.rst
This was referenced Sep 29, 2025
ahcorde
pushed a commit
that referenced
this pull request
Sep 29, 2025
(cherry picked from commit c87aa57) Signed-off-by: Christoph Fröhlich <[email protected]> Co-authored-by: Christoph Fröhlich <[email protected]>
ahcorde
added a commit
that referenced
this pull request
Sep 29, 2025
* Update Pluginlib.rst (#5894) Signed-off-by: Christoph Fröhlich <[email protected]> (cherry picked from commit c87aa57) Signed-off-by: Alejandro Hernandez Cordero <[email protected]> Co-authored-by: Christoph Fröhlich <[email protected]> Co-authored-by: Alejandro Hernandez Cordero <[email protected]>
ahcorde
added a commit
that referenced
this pull request
Sep 29, 2025
* Update Pluginlib.rst (#5894) Signed-off-by: Christoph Fröhlich <[email protected]> (cherry picked from commit c87aa57) Signed-off-by: Alejandro Hernandez Cordero <[email protected]> Co-authored-by: Christoph Fröhlich <[email protected]> Co-authored-by: Alejandro Hernandez Cordero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pluginlib page has some issues.
First, I don't think that the area_node should be part of the library:
add_library(${PROJECT_NAME} SHARED src/area_node.cpp)As proposed here I changed it to be an
INTERFACElibrary.As a consequence,
does not work any more.
Additionally,
was a duplicate with different destination.