Skip to content

RDoc for converters #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 15, 2020
Merged

RDoc for converters #157

merged 3 commits into from
Jul 15, 2020

Conversation

@BurdetteLamar
Copy link
Member

@BurdetteLamar BurdetteLamar commented Jul 15, 2020

This PR had to be this big because of cross-referencing (links) and to avoid redundancy.

@BurdetteLamar BurdetteLamar requested a review from kou July 15, 2020 18:47
kou
kou reviewed Jul 15, 2020
View reviewed changes
@kou kou changed the title Rdoc for converters RDoc for converters Jul 15, 2020
@kou kou merged commit 6044976 into ruby:master Jul 15, 2020
@kou
Copy link
Member

kou commented Jul 15, 2020

Thanks.

@BurdetteLamar
Copy link
Member Author

BurdetteLamar commented Jul 18, 2020

@kou, does this eventually get merged into ruby/ruby?

@kou
Copy link
Member

kou commented Jul 18, 2020

Yes.
But we need to consider where we should put separated documents in ruby/ruby before we put our changes to ruby/ruby.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kou kou kou left review comments

Assignees

No one assigned

Labels

Documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BurdetteLamar @kou