Introducing test coverage report - Closes #49 #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be provided by SimpleCov gem, on every run will generate a report for the code coverage
esparta
force-pushed
the
introducing_test_coverage_report
branch
from
14ea1f5 to
ed42a7c
Compare
Also include the CodeClimate badge on the README.md
kou
reviewed
Nov 16, 2018
| @@ -9,6 +9,9 @@ | |||
| require 'test/unit/testcase' | |||
| require 'optparse' | |||
|
|
|||
| require 'simplecov' | |||
| SimpleCov.start | |||
|
|
|||
There was a problem hiding this comment.
Can we enable this code only when we run our tests on Travis CI?
There was a problem hiding this comment.
Yes, we can use travis ENVs and restrict the execution based on that. I'll push a change for that.
There was a problem hiding this comment.
Added the restriction to CI env.
|
I've updated test reporter ID. |
esparta
force-pushed
the
introducing_test_coverage_report
branch
from
5609941 to
8f292fc
Compare
Contributors can enable the coverage just setting the ENV variable CI* to a truthy value: Bash compatible ``` CI=true rake ``` Fish ``` ENV CI=true rake ``` * travis CI set this by default on all executions: https://docs.travis-ci.com/user/environment-variables/
kou
approved these changes
Nov 16, 2018
| @@ -9,6 +9,9 @@ | |||
| require 'test/unit/testcase' | |||
| require 'optparse' | |||
|
|
|||
| require 'simplecov' | |||
| SimpleCov.start | |||
|
|
|||
|
I've merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #49: Proposal: Test coverage report for the project
We must change the CodeClimate TestID:
https://codeclimate.com/github/ruby/csv -> Repo Settings -> Test Coverage -> Test reporter ID
Please use that ID as a code suggestion, and we can merge using ruby/csv token instead of my personal one (on .travis.yml.)