[CHORE] Duplicate definition of _header #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
requested changes
Jan 12, 2019
| @@ -1243,9 +1243,11 @@ def inspect | |||
| str << " " << attr_name << ":" << a.inspect | |||
| end | |||
| end | |||
| _headers = headers | |||
| _headers = headers | |||
There was a problem hiding this comment.
I prefer to just remove this line.
I don't want to call the same method twice.
maschwenk
force-pushed
the
duplicate-headrs-definition
branch
from
a847cb0 to
42893fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm unsure what this code was originally trying to work around but I think this change makes more sense and is functionally the same.
Perhaps at some point calculating
headerswas expensive?